Generally anything in the 2XX space is considered a successful call.

[shinjonathan]

true-github-contributors/trueContributors-mixin.js

Line 54 in 3b069f7

if(res.status != 204 || res.headers.status != "204 No Content") throw err;

[KianBadie]

Thank you again @shinjonathan! I think my original intention with that is regarding this issue here. I was calling octokit's paginate function (which basically just aggregates all the paginated data of a given endpoint) for the listContributors endpoint on an empty repository, which returned a TypeError. However, if I called the listContributors function on the empty repo, it seems to return a response with a 204 code. The issue I linked seems to show that this is not intended, as expressed in this comment. So my workaround/mindset was "if I get an error from the paginate function for listContributors, check if using the non paginated version (listContributors in this case) returns the 204 code. If it is the 204 code, it means paginate was called on an empty repo. If not 204, then it is some error I do not know about and I want to propagate it."

Given that explanation, do you think it is justifiable to be on the specific lookout for code 204 like I was doing? Or do you think I should still change something?