fix(IBA): reorient() cases for transpose and transverse (#5350)

Orientations 5 and 7 were swapped: case 5 produced transverse and case 7
produced transpose. Fix both cases.

This adds reorient() tests covering all 8 values to the oiiotool-xform
testsuite, and updates the python-imagebufalgo reorient() test to use
the new test image for consistency.

Also, add orientation example images to documentation.

Fixes #4661

Signed-off-by: Luna Kim <177369799+luna-y-kim@users.noreply.github.com>

Author: luna-y-kim

src/doc/figures/orientation1.jpg

@@ -74,6 +74,22 @@ Description of the image
 Display hints
 =============
 
+.. |orient1img| image:: figures/orientation1.jpg
+    :height: 1 in
+.. |orient2img| image:: figures/orientation2.jpg
+    :height: 1 in
+.. |orient3img| image:: figures/orientation3.jpg
+    :height: 1 in
+.. |orient4img| image:: figures/orientation4.jpg
+    :height: 1 in
+.. |orient5img| image:: figures/orientation5.jpg
+    :width: 1 in
+.. |orient6img| image:: figures/orientation6.jpg
+    :width: 1 in
+.. |orient7img| image:: figures/orientation7.jpg
+    :width: 1 in
+.. |orient8img| image:: figures/orientation8.jpg
+    :width: 1 in
 
 .. option:: "Orientation" : int
 
@@ -83,16 +99,16 @@ Display hints
     `"Orientation"` field can suggest that it should be displayed with
     a different orientation, according to the TIFF/EXIF conventions:
 
-    ===  ==========================================================================
-     1   normal (top to bottom, left to right)
-     2   flipped horizontally (top to bottom, right to left)
-     3   rotated :math:`180^\circ` (bottom to top, right to left)
-     4   flipped vertically (bottom to top, left to right)
-     5   transposed (left to right, top to bottom)
-     6   rotated :math:`90^\circ` clockwise (right to left, top to bottom)
-     7   transverse (right to left, bottom to top)
-     8   rotated :math:`90^\circ` counter-clockwise (left to right, bottom to top)
-    ===  ==========================================================================
+    ===  ============  ==========================================================================
+     1   |orient1img|  normal (top to bottom, left to right)
+     2   |orient2img|  flipped horizontally (top to bottom, right to left)
+     3   |orient3img|  rotated :math:`180^\circ` (bottom to top, right to left)
+     4   |orient4img|  flipped vertically (bottom to top, left to right)
+     5   |orient5img|  transposed (left to right, top to bottom)
+     6   |orient6img|  rotated :math:`90^\circ` clockwise (right to left, top to bottom)
+     7   |orient7img|  transverse (right to left, bottom to top)
+     8   |orient8img|  rotated :math:`90^\circ` counter-clockwise (left to right, bottom to top)
+    ===  ============  ==========================================================================
 
 .. option:: "PixelAspectRatio" : float
 

src/doc/figures/orientation2.jpg

@@ -363,15 +363,15 @@ ImageBufAlgo::reorient(ImageBuf& dst, const ImageBuf& src, int nthreads)
     case 3: ok = ImageBufAlgo::rotate180(dst, src, ROI(), nthreads); break;
     case 4: ok = ImageBufAlgo::flip(dst, src, ROI(), nthreads); break;
     case 5:
-        ok = ImageBufAlgo::rotate270(tmp, src, ROI(), nthreads);
+        ok = ImageBufAlgo::rotate90(tmp, src, ROI(), nthreads);
         if (ok)
             ok = ImageBufAlgo::flop(dst, tmp, ROI(), nthreads);
         else
             dst.errorfmt("{}", tmp.geterror());
         break;
     case 6: ok = ImageBufAlgo::rotate90(dst, src, ROI(), nthreads); break;
     case 7:
-        ok = ImageBufAlgo::flip(tmp, src, ROI(), nthreads);
+        ok = ImageBufAlgo::flop(tmp, src, ROI(), nthreads);
         if (ok)
             ok = ImageBufAlgo::rotate90(dst, tmp, ROI(), nthreads);
         else