ITSMFT: share tracking slab allocation primitives - #15730
Conversation
|
Error while checking build/O2/fullCI_slc9 for 9f24e0b at 2026-08-28 02:26: Full log here. |
f3sch
left a comment
f3sch
left a comment
There was a problem hiding this comment.
PR is mostly noise from bounded_vector to o2::itsmft::tracking::bounded_vector where a using decl. would have sufficed. This is fine I guess. See some comments below.
Changed the header include in AliceO2Group/QualityControl#2687
|
|
||
| std::string BoundedMemoryResource::asString() const | ||
| { | ||
| constexpr double gigabyte = 1024. * 1024. * 1024.; |
There was a problem hiding this comment.
if we have constants.h here now lets remove this extra
| void update(uint64_t key, double scale, size_t emitted, size_t capacityUsed, bool overflowed, bool memoryLimited); | ||
| void update(uint64_t key, double scale, size_t requested, size_t granted, size_t emitted, | ||
| size_t spilled, bool overflowed, bool memoryLimited); | ||
| template <typename Stats> |
There was a problem hiding this comment.
I don't see a reason to template this?
| float ratio{0.f}; | ||
| float margin{0.f}; | ||
| size_t maxEmitted{0}; | ||
| uint32_t nLowStreak{0}; |
There was a problem hiding this comment.
Should not nLowStreak and mAxEmitted also go into Statistics?
| o2_add_test(roflookuptables | ||
| SOURCES testROFLookupTables.cxx | ||
| COMPONENT_NAME its-tracking |
There was a problem hiding this comment.
you are moving the whole class header to the common and both other test but leave roflookuptables test?
should be moved as well.
| T* staging; | ||
| int32_t* producerOf; | ||
| bounded_vector<T>* destination; | ||
| } context{mStaging.data(), mProducerOf.data(), &dest}; |
There was a problem hiding this comment.
personally I don't like these immediate structs, maybe move definition into the detail?
3 participants
No description provided.