Repository navigation
Conversation
ktf
previously approved these changes
Oct 14, 2026
ktf
left a comment
ktf
left a comment
Member
There was a problem hiding this comment.
Fine with me if passes the tests.
Meta::name was a strdup'ed char const* that was never freed. Use std::string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TestWSHandler stored strdup'ed copies of every frame and never freed them. Keep the frames in a std::vector<std::string> instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The buffers produced by encode_websocket_frames are malloc'ed and were never released. Free them at the end of each test block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Request and frame inputs were strdup'ed and never freed. Use string_view on literals, make parse_http_request take char const*, and free the malloc'ed buffers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The objects returned by the deserialization helpers were never deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inputs array allocated by the test was never released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aalkin
force-pushed
the
add-leaks-test-on-macos
branch
from
October 14, 2026 12:22
65aa13d to
7931f5e
Compare
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XCode provide a convenient command-line memory leak detection utility. This change wraps framework:core test with it. There is plenty of memory leaks which means the test fails, this PR will be used to monitor gradual fixing of the leaks.