[PWGCF] Fix string forming issue (#17567)

Author: ktf

PWGCF/FemtoDream/Core/femtoDreamObjectSelection.h

@@ -24,6 +24,8 @@
 
 #include <TH1.h>
 
+#include <fmt/format.h>
+
 #include <algorithm>
 #include <cstddef>
 #include <string>
@@ -52,7 +54,11 @@ class FemtoDreamObjectSelection
   void fillSelectionHistogram()
   {
     int nBins = mSelections.size();
-    mQAHistogramRegistry->add((static_cast<std::string>(o2::aod::femtodreamparticle::ParticleTypeName[part]) + "/cuthist").c_str(), "; Cut; Value", o2::framework::HistType::kTH1F, {{nBins, 0, static_cast<double>(nBins)}});
+    // fmt::format, not std::string + const char*: the longest names here are
+    // exactly 32 characters, so the concatenation crosses std::string's SSO
+    // boundary and GCC 14 reports the constant-folded copy as
+    // -Werror=array-bounds= on a buffer that is never actually used.
+    mQAHistogramRegistry->add(fmt::format("{}/cuthist", o2::aod::femtodreamparticle::ParticleTypeName[part]).c_str(), "; Cut; Value", o2::framework::HistType::kTH1F, {{nBins, 0, static_cast<double>(nBins)}});
     auto hist = mQAHistogramRegistry->get<TH1>(HIST(o2::aod::femtodreamparticle::ParticleTypeName[part]) + HIST("/cuthist"));
     for (size_t i = 0; i < mSelections.size(); ++i) {
       hist->GetXaxis()->SetBinLabel(i + 1, Form("%u", mSelections.at(i).getSelectionVariable()));

PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h

@@ -28,6 +28,8 @@
 #include <TMath.h>
 #include <TPDGCode.h>
 
+#include <fmt/format.h>
+
 #include <cstdlib>
 #include <string>
 #include <string_view>
@@ -340,7 +342,7 @@ class FemtoDreamParticleHisto
       framework::AxisSpec InvMassAxis = {InvMassBins, "M_{inv} (GeV/#it{c}^{2})"};
       framework::AxisSpec InvMassCompetingAxis = {InvMassCompetingBins, "M_{inv} (GeV/#it{c}^{2})"};
 
-      std::string folderName = (static_cast<std::string>(o2::aod::femtodreamparticle::ParticleTypeName[mParticleType]).c_str() + static_cast<std::string>(mFolderSuffix[mFolderSuffixType])).c_str();
+      std::string folderName = fmt::format("{}{}", o2::aod::femtodreamparticle::ParticleTypeName[mParticleType], mFolderSuffix[mFolderSuffixType]);
 
       // Fill here the actual histogramms by calling init_base and init_MC
       init_base<o2::aod::femtodreamMCparticle::MCType::kRecon>(folderName, tempFitVarAxisTitle, pTAxis, tempFitVarAxis, InvMassAxis, multAxis);

PWGCF/FemtoDream/Core/femtoDreamTrackSelection.h

@@ -29,6 +29,8 @@
 #include <Framework/Logger.h>
 #include <ReconstructionDataFormats/PID.h>
 
+#include <fmt/format.h>
+
 #include <array>
 #include <cmath>
 #include <cstddef>
@@ -313,7 +315,7 @@ void FemtoDreamTrackSelection::init(o2::framework::HistogramRegistry* QAregistry
   if (QAregistry && Registry) {
     mHistogramRegistry = Registry;
     mQAHistogramRegistry = QAregistry;
-    std::string folderName = static_cast<std::string>(o2::aod::femtodreamparticle::ParticleTypeName[part]) + "/" + static_cast<std::string>(o2::aod::femtodreamparticle::TrackTypeName[tracktype]);
+    std::string folderName = fmt::format("{}/{}", o2::aod::femtodreamparticle::ParticleTypeName[part], o2::aod::femtodreamparticle::TrackTypeName[tracktype]);
 
     /// check whether the number of selection exceeds the bitmap size
     unsigned int nSelections = getNSelections() - getNSelections(femtoDreamTrackSelection::kPIDnSigmaMax);

PWGCF/FemtoDream/Core/femtoDreamV0Selection.h

@@ -28,6 +28,8 @@
 #include <Framework/HistogramSpec.h>
 #include <Framework/Logger.h>
 
+#include <fmt/format.h>
+
 #include <array>
 #include <cstddef>
 #include <cstdlib>
@@ -304,8 +306,8 @@ void FemtoDreamV0Selection::init(o2::framework::HistogramRegistry* QAregistry, o
     }
     for (int istage = 0; istage < femtoDreamSelection::kNcutStages; istage++) {
       std::string folderName =
-        static_cast<std::string>(o2::aod::femtodreamparticle::ParticleTypeName[part]) + "/" +
-        static_cast<std::string>(femtoDreamSelection::mCutStage[istage]);
+        fmt::format("{}/{}", o2::aod::femtodreamparticle::ParticleTypeName[part],
+                    femtoDreamSelection::mCutStage[istage]);
       /// \todo initialize histograms for children tracks of v0s
       mQAHistogramRegistry->add((folderName + "/hPt").c_str(),
                                 "; #it{p}_{T} (GeV/#it{c}); Entries", o2::framework::HistType::kTH1F,