Skip to content

chore: re-enable [10/10] no-internet models.dev sanity test once soaked #1145

Description

@anandgupta42

Follow-up from the D14 fix in 205a953 (#1085), noted again during v0.9.7 release review (CTO persona).

The eager import-time ModelsDev.refresh() fetch was removed to fix a CI hang (unshare --net blocked DNS resolution past process exit). However, ModelsDev.Data() still falls through to the same unbounded fetchApi() whenever both the disk cache and the bundled snapshot are absent — true in dev-mode builds without the embedded snapshot. The reduction is real but not a full close.

test/sanity/phases/resilience.sh's [10/10] no-internet graceful handling test remains SKIPPED pending 'soak through one release' per the original commit message. Re-evaluate re-enabling it after v0.9.7 has been live for a cycle.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions