Skip to content
This repository was archived by the owner on Jul 28, 2020. It is now read-only.
This repository was archived by the owner on Jul 28, 2020. It is now read-only.

Function name/header casing causes thrift crash #9

@mduleone

Description

@mduleone

When thrift@0.7.0 receives an error and tries to call the function on the client object through client['recv_' + header.fname](message, header.mtype, dummy_seqid); (line #83 of thrift/lib/thrift/connection.js of thrift@0.7.0), header.fname = 'log'. The associated function is defined here: https://github.com/Applifier/node-scribe/blob/master/lib/gen-nodejs/scribe.js#L156, as recv_Log (capital L instead of lowercase like header.fname). This causes thrift@0.7.0 to choke and the app to crash.

Issue #7 would resolve this issue for the most part, as the latest version of thrift checks for the existence of client['recv_' + header.fname] before invoking it, https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/connection.js;h=23cb01c79b6b839f020bfcb67bc0875221e94564;hb=HEAD#l138

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions