Skip to content

PHP 8.4 Deprecation warning for the CappedPostRanker #41

Description

@markbiek

When updating StreamBuilder on WordPress.com to 0.12.1, I got the following PHP 8.4 deprecation warning:

Deprecated: Tumblr\StreamBuilder\StreamRankers\CappedPostRanker::__construct(): Optional parameter $debug declared before required parameter $panel_allow_ranking is implicitly treated as a required parameter in wp-content/lib/stream-builder/sun/vendor/automattic/stream-builder/lib/Tumblr/StreamBuilder/StreamRankers/CappedPostRanker.php on line 70

185493-ghe-Automattic/wpcom

It's not an error deprecation yet so there's time to fix it but I'm not sure what the implications are for breaking compatibility on the constructor for the CappedPostRanker.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions