Skip to content

Commit eabc4b7

Browse files
committed
Clarify SQLite PDO accessor
Rename the export helper to make explicit that it returns the underlying SQLite PDO connection.
1 parent cc958e3 commit eabc4b7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎src/Export.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ protected function get_create_statement( $table_name ) {
197197
*/
198198
protected function get_insert_statements( $table_name ) {
199199
$quoted_table_name = $this->quote_identifier( $table_name );
200-
$stmt = $this->get_pdo()->query( 'SELECT * FROM ' . $quoted_table_name );
200+
$stmt = $this->get_sqlite_pdo()->query( 'SELECT * FROM ' . $quoted_table_name );
201201
// phpcs:ignore
202202
while ( $row = $stmt->fetch( PDO::FETCH_ASSOC, PDO::FETCH_ORI_NEXT ) ) {
203203
yield sprintf( 'INSERT INTO %1s VALUES (%2s);', $quoted_table_name, $this->escape_values( $row ) );
@@ -310,7 +310,7 @@ protected function get_dump_comment( $comment ) {
310310
*/
311311
protected function table_has_records( $table_name ) {
312312
$table_name = $this->quote_identifier( $table_name );
313-
$stmt = $this->get_pdo()->query( 'SELECT COUNT(*) FROM ' . $table_name );
313+
$stmt = $this->get_sqlite_pdo()->query( 'SELECT COUNT(*) FROM ' . $table_name );
314314
return $stmt->fetchColumn() > 0;
315315
}
316316

@@ -325,11 +325,11 @@ protected function quote_identifier( $identifier ) {
325325
}
326326

327327
/**
328-
* Get the PDO instance.
328+
* Get the underlying SQLite PDO instance.
329329
*
330330
* @return PDO
331331
*/
332-
protected function get_pdo() {
332+
protected function get_sqlite_pdo() {
333333
if ( $this->driver instanceof WP_SQLite_Translator ) {
334334
return $this->driver->get_pdo();
335335
}

0 commit comments

Comments
 (0)