Skip to content

Commit f71faef

Browse files
Merge pull request #1611 from AxiomCodeAI/fix/1593-engine-id-once
engine: generate the Souffle program once and hash that file for the engine id (#1593)
2 parents aef5bf5 + 2526b86 commit f71faef

4 files changed

Lines changed: 298 additions & 57 deletions

File tree

‎.github/RELEASING.md‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,7 @@ from Actions at any time (it publishes only if you tick `publish`).
6666

6767
Compiled engines are cached by ENGINE_ID, the hash of a language's rules and the Soufflé version,
6868
so a change that touches no rules reuses every engine and a rule change recompiles only its own
69-
language. The nightly and every real publish build fresh.
69+
language. Precisely: sha256 over the pinned Soufflé version, the bytes of the program file that is
70+
compiled, and every file it includes, in include order. The program is generated once, verified and
71+
then hashed, so the id is path-independent (the same from any checkout) and rule-sensitive (any rule,
72+
map or manifest change moves it), and it never comes from a second rendering of the program (#1593). The nightly and every real publish build fresh.

0 commit comments

Comments
 (0)