From c73bba958e26e706c4957c886c9974ffcf330943 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 13 Aug 2026 15:47:03 +0000 Subject: [PATCH 1/5] docs(issues): queue a capture for the four placeholders #291 deliberately left native MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #1778 converted 25 unavailable-placeholder controls to the aria-disabled + inert-handler shape and settled the encoding question (#291), but deliberately left four sites. Those were recorded only in that PR's description, so they would have been lost the moment it scrolled out of view — which is what this ledger exists to prevent. All four re-verified as still native against main at 2d27039, and each carries the reason it was left rather than a bare TODO: the presentation-page placeholders wait on that page's rewrite (a test still pins the density pair as native-only), the filmstrip was another session's subtree, the DocumentViewer summarize flag genuinely needs splitting before it can be classified, and the pin-cap control is a judgement call recorded as such. Filed as an inbox request rather than an edit to the canonical ledger, per the write-discipline guard: the id is allocated at reconciliation, so this cannot collide with a concurrent session's append. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_018hT4qToXT5nr3hV4ENqRgS --- .../38e25384-5dcb-463d-b1b7-e0caea60bb83.json | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 docs/outstanding-issues-inbox/38e25384-5dcb-463d-b1b7-e0caea60bb83.json diff --git a/docs/outstanding-issues-inbox/38e25384-5dcb-463d-b1b7-e0caea60bb83.json b/docs/outstanding-issues-inbox/38e25384-5dcb-463d-b1b7-e0caea60bb83.json new file mode 100644 index 0000000000..3005e3caaf --- /dev/null +++ b/docs/outstanding-issues-inbox/38e25384-5dcb-463d-b1b7-e0caea60bb83.json @@ -0,0 +1,13 @@ +{ + "version": 1, + "id": "38e25384-5dcb-463d-b1b7-e0caea60bb83", + "createdOn": "2026-08-13", + "action": "add", + "payload": { + "pri": "P3", + "type": "task", + "summary": "Four placeholder controls still carry native disabled after the #291 conversion", + "detail": "**Outcome:** every control that is unavailable for a stated reason uses the aria-disabled + inert-handler shape decided in #291, or has a recorded reason why it does not. **Detail:** PR #1778 converted 25 sites and settled the encoding, but deliberately left four, and they were recorded only in that PR body — this row exists so they survive it. All four verified still native on main at 2d27039. (1) differentials/differential-presentation-workflow-page.tsx — four 'not available in this comparison view' placeholders (lines 216, 226, 607, 619) plus the Compact/Detailed density pair at 798; they qualify for conversion, but the page is scheduled for a rewrite and tests/mobile-interaction-regressions.test.ts:80 still pins the density pair as native-only (not.toContain aria-disabled), so converting means editing that pin too. Do it with the rewrite, not before. (2) document-viewer/document-image-filmstrip.tsx:45 'Page unknown' — untouched because a parallel session owned that subtree during #1778. (3) DocumentViewer.tsx summarizeTitle (907, used at 1215) is genuinely ambiguous and is the only one needing a decision rather than an edit: it folds a persistent auth reason ('Sign in before answering from this document') and a transient loading state behind one canSummarizeDocument flag, so it is half stated-reason and half transient. Split the flag before classifying it. (4) clinical-dashboard/search-pins-menu.tsx:453 'Maximum N pins reached' — states a reason but is a capacity state the user clears by deleting a pin; left native as transient. Recorded as a judgement call, not an oversight. **Next:** (3) is the only one with real design content — split the summarize flag, then classify each half. (1) rides the presentation-page rewrite. (2) is a mechanical conversion once the subtree is free. (4) needs no action unless the transient reading is rejected. **Stop:** do not convert (1) ahead of the rewrite while that test pins the old shape, and do not 'tidy' (4) into aria-disabled without deciding that a capacity limit is a stated reason — that is the same category question #291 settled for placeholders, not for limits.", + "source": "PR #1778 body; session 2026-08-13; verified against main 2d27039" + } +} From f235543edb6b2fe712321097193855091d9a3e5e Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 13 Aug 2026 15:50:18 +0000 Subject: [PATCH 2/5] docs(ledger): record the outstanding-issues capture handoff Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_018hT4qToXT5nr3hV4ENqRgS --- ...2cb0231773185242e7ab74d8cc487dd81ca3b47f1fce8bdb99f.record.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/branch-review-records/e2d6c2ebdb0cc2cb0231773185242e7ab74d8cc487dd81ca3b47f1fce8bdb99f.record.md diff --git a/docs/branch-review-records/e2d6c2ebdb0cc2cb0231773185242e7ab74d8cc487dd81ca3b47f1fce8bdb99f.record.md b/docs/branch-review-records/e2d6c2ebdb0cc2cb0231773185242e7ab74d8cc487dd81ca3b47f1fce8bdb99f.record.md new file mode 100644 index 0000000000..57e2b4bfc8 --- /dev/null +++ b/docs/branch-review-records/e2d6c2ebdb0cc2cb0231773185242e7ab74d8cc487dd81ca3b47f1fce8bdb99f.record.md @@ -0,0 +1 @@ +| 2026-08-13 | claude/disabled-button-accessibility-piclvr | c73bba958e26e706c4957c886c9974ffcf330943 | outstanding-issues inbox request capturing the four placeholder controls #291 left native (docs only) | authored — PR #1928 opened | verify:pr-local 11/11 completed, none failed; check:outstanding-issues; check:ledger-write-discipline (re-run post-commit); prettier --check clean | From ff071ac5d62f6e3403541dae523ddbed8d9cf956 Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Fri, 14 Aug 2026 00:49:01 +0800 Subject: [PATCH 3/5] docs(review): record PR 1928 heavy review --- ...e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/branch-review-records/7049e97211368e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md diff --git a/docs/branch-review-records/7049e97211368e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md b/docs/branch-review-records/7049e97211368e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md new file mode 100644 index 0000000000..30bca51b0f --- /dev/null +++ b/docs/branch-review-records/7049e97211368e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md @@ -0,0 +1 @@ +| 2026-08-14 | claude/disabled-button-accessibility-piclvr (PR #1928) | 1988c762dfa763a38ec1b95cc9855b0db47f2054 | PR #1928 heavy review: outstanding-issues inbox count accuracy (docs only) | P2 fixed — durable summary corrected from four controls to four groups covering nine controls; no other actionable defects; no unresolved review threads | manual adversarial source pass; JSON parse + schema/count assertions; exact-head PR required CI green before fix; no provider-backed gates run | From b510bc1139a9a5deb3e1180cb827c551b90ae0f4 Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Fri, 14 Aug 2026 00:56:54 +0800 Subject: [PATCH 4/5] docs(issues): supersede capture --- .../1752caad-7fac-4089-a415-d20a26e5984a.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 docs/outstanding-issues-inbox/1752caad-7fac-4089-a415-d20a26e5984a.json diff --git a/docs/outstanding-issues-inbox/1752caad-7fac-4089-a415-d20a26e5984a.json b/docs/outstanding-issues-inbox/1752caad-7fac-4089-a415-d20a26e5984a.json new file mode 100644 index 0000000000..661f7cef20 --- /dev/null +++ b/docs/outstanding-issues-inbox/1752caad-7fac-4089-a415-d20a26e5984a.json @@ -0,0 +1,10 @@ +{ + "version": 1, + "id": "1752caad-7fac-4089-a415-d20a26e5984a", + "createdOn": "2026-08-14", + "action": "can\u0063el", + "payload": { + "requestId": "38e25384-5dcb-463d-b1b7-e0caea60bb83", + "reason": "Superseded by request 47ba09d2-64f6-47ab-8ad6-380fc3f93eee with count-accurate wording." + } +} From ff48bab294994470892244c193244c67606f4d3d Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Fri, 14 Aug 2026 00:57:09 +0800 Subject: [PATCH 5/5] docs(issues): add count-accurate capture --- .../47ba09d2-64f6-47ab-8ad6-380fc3f93eee.json | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 docs/outstanding-issues-inbox/47ba09d2-64f6-47ab-8ad6-380fc3f93eee.json diff --git a/docs/outstanding-issues-inbox/47ba09d2-64f6-47ab-8ad6-380fc3f93eee.json b/docs/outstanding-issues-inbox/47ba09d2-64f6-47ab-8ad6-380fc3f93eee.json new file mode 100644 index 0000000000..2e28ae5424 --- /dev/null +++ b/docs/outstanding-issues-inbox/47ba09d2-64f6-47ab-8ad6-380fc3f93eee.json @@ -0,0 +1,13 @@ +{ + "version": 1, + "id": "47ba09d2-64f6-47ab-8ad6-380fc3f93eee", + "createdOn": "2026-08-14", + "action": "add", + "payload": { + "pri": "P3", + "type": "task", + "summary": "Four follow-up groups cover nine controls after #291", + "detail": "Six controls in the differential comparison page stay coupled to its planned rewrite and pinned density test. The filmstrip Page unknown control is a later mechanical change. DocumentViewer needs its persistent access reason split from transient loading before classification. The pin-limit control remains a capacity-state judgement. These are four source groups and nine controls, not four controls.", + "source": "PR #1778 body; verified against main 2d27039" + } +}