From 37cd0a06a251dcd1afcda124e4b6bd07f88d174a Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Fri, 21 Aug 2026 22:05:42 +0800 Subject: [PATCH 1/2] docs(issues): queue two spec closures backed by a first-hand test run, and a count correction Codex review on PR #2229 flagged that the reconciliation cancelled two done requests whose evidence was exactly the re-measurement #SZGPAH and #4TBHS8 were waiting for, without preserving it. The cancellation authors said the same thing and recommended fresh done requests be queued. Rather than close on their claim, the spec was re-run here: 16 passed (1.5m), exit 0, with both previously-failing tests green by name. Also corrects #VTEW3W, whose earlier update counted raw text occurrences (21 across 8 files) against a call-site baseline. Measured properly it is 13 call sites across 7 files. Co-Authored-By: Claude Opus 5 --- .../51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json | 11 +++++++++++ .../5d987a3d-3869-4864-8af0-de0a6145b682.json | 11 +++++++++++ .../c1f99542-526a-4218-b8e6-87bf136d7567.json | 11 +++++++++++ 3 files changed, 33 insertions(+) create mode 100644 docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json create mode 100644 docs/outstanding-issues-inbox/5d987a3d-3869-4864-8af0-de0a6145b682.json create mode 100644 docs/outstanding-issues-inbox/c1f99542-526a-4218-b8e6-87bf136d7567.json diff --git a/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json b/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json new file mode 100644 index 0000000000..e64b778982 --- /dev/null +++ b/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json @@ -0,0 +1,11 @@ +{ + "version": 2, + "id": "51b7e3d4-9c38-4fd7-9aa8-70d46086fde9", + "createdOn": "2026-08-21", + "action": "update", + "payload": { + "id": "#VTEW3W", + "detail": "CORRECTION 2026-08-21, superseding the update applied earlier the same day: the count of 21 across 8 files recorded by that update was WRONG, and the 13 across 7 files measured by the request cancelled as c6a9756d is RIGHT. The discrepancy flagged in that cancellation is now resolved by direct re-measurement on main rather than by choosing between the two numbers. Cause of the error: the earlier update counted raw textual occurrences of therapyBtn, which includes one import statement per consuming file plus the export in controls.ts, and then compared that total against a baseline expressed in CALL SITES. That is an apples-to-oranges comparison and it overstated the remaining work. Measured per file, excluding the import line in each and excluding the definition: brief-screen 1, compare-screen 1, detail-screen 1, pathways-screen 1, recommend-screen 1, sheets-screen 7, therapy-card 1 = 13 call sites across 7 .tsx files, with the export at controls.ts:26. Against the 30 call sites recorded 2026-08-18 at adf93a75, that is a real reduction of 17, not the 9 the bad arithmetic implied. The design question and the stop rule are unchanged: nothing shared covers list rows, disclosure headers, section toggles and chips, and this must not be resolved by converting the remaining sites to Button variants.", + "baseRowFingerprint": "731faf770b9414607177a3e24ae530d98479a5c5f65547da063825563bf711f4" + } +} diff --git a/docs/outstanding-issues-inbox/5d987a3d-3869-4864-8af0-de0a6145b682.json b/docs/outstanding-issues-inbox/5d987a3d-3869-4864-8af0-de0a6145b682.json new file mode 100644 index 0000000000..8b981cf409 --- /dev/null +++ b/docs/outstanding-issues-inbox/5d987a3d-3869-4864-8af0-de0a6145b682.json @@ -0,0 +1,11 @@ +{ + "version": 2, + "id": "5d987a3d-3869-4864-8af0-de0a6145b682", + "createdOn": "2026-08-21", + "action": "done", + "payload": { + "id": "#SZGPAH", + "outcome": "Resolved 2026-08-21. Re-measured first-hand on 2026-08-21 at HEAD e4df772e3712620a8d64dc28843048e32bde88ee: node scripts/run-playwright.mjs --project=chromium-mockups tests/ui-tools-search-mode-mockup.spec.ts reported '16 passed (1.5m)' with exit code 0. Both previously-failing tests are green by name: test 1, 'desktop uses universal search and keeps results beside the selected-tool panel' (spec line 24, 10.9s), and test 9, 'phone filter sheet follows the shared local-filter behavior' (spec line 194, 4.5s). This independently reproduces the run at a341832af cited by the request cancelled as 3eb84c6a-97fa-4b1c-9167-190ba928c200, whose author explicitly recommended that a fresh done request be queued so the evidence would not be lost; that recommendation is what this request carries out. The rows are therefore closed on a reproduced measurement, not on a third-party claim. The advisory lane is no longer red for every UI PR from this spec. Note for the record: the 2026-08-21 update on this row said 'NOT VERIFIED: whether the spec now passes ... Re-measure before closing' - that re-measurement has now been done and is the basis for this closure.", + "baseRowFingerprint": "7b4cfefa46485dc95291481287de889362d2241b6bdc18599b969ef11f7ee5b7" + } +} diff --git a/docs/outstanding-issues-inbox/c1f99542-526a-4218-b8e6-87bf136d7567.json b/docs/outstanding-issues-inbox/c1f99542-526a-4218-b8e6-87bf136d7567.json new file mode 100644 index 0000000000..b2e5304520 --- /dev/null +++ b/docs/outstanding-issues-inbox/c1f99542-526a-4218-b8e6-87bf136d7567.json @@ -0,0 +1,11 @@ +{ + "version": 2, + "id": "c1f99542-526a-4218-b8e6-87bf136d7567", + "createdOn": "2026-08-21", + "action": "done", + "payload": { + "id": "#4TBHS8", + "outcome": "Resolved 2026-08-21. Re-measured first-hand on 2026-08-21 at HEAD e4df772e3712620a8d64dc28843048e32bde88ee: node scripts/run-playwright.mjs --project=chromium-mockups tests/ui-tools-search-mode-mockup.spec.ts reported '16 passed (1.5m)' with exit code 0. Both previously-failing tests are green by name: test 1, 'desktop uses universal search and keeps results beside the selected-tool panel' (spec line 24, 10.9s), and test 9, 'phone filter sheet follows the shared local-filter behavior' (spec line 194, 4.5s). This independently reproduces the run at a341832af cited by the request cancelled as 1a175782-d9cf-4de6-a67b-d3b2da632c84, whose author explicitly recommended that a fresh done request be queued so the evidence would not be lost; that recommendation is what this request carries out. The rows are therefore closed on a reproduced measurement, not on a third-party claim. The specific failure recorded here - waiting for the exact text '2 showing' inside the tools-search-filter-sheet testid - is gone with the rewritten assertion, and the rewritten test passes. Tracked with #SZGPAH, which named the same spec file and closed on the same run.", + "baseRowFingerprint": "3769f42e3e4a417bbb9b3e2c30200a08eaa98eb879a95bc569b3d37dda2e95ca" + } +} From d7771f3ddbca17ce868f4ecb0adc08779bb487fc Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 21 Aug 2026 14:35:32 +0000 Subject: [PATCH 2/2] Add corrected summary field to the #VTEW3W ledger-update request Codex review correctly noted that applyRequest/updateIssue only touches fields present in the payload, so an update carrying detail alone would leave the row's summary column still reading "30 raw controls across 8 files" after reconciliation, contradicting the corrected 13-across-7 detail. Added the matching summary field. --- .../51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json b/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json index e64b778982..2ce689f7b2 100644 --- a/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json +++ b/docs/outstanding-issues-inbox/51b7e3d4-9c38-4fd7-9aa8-70d46086fde9.json @@ -5,6 +5,7 @@ "action": "update", "payload": { "id": "#VTEW3W", + "summary": "therapyBtn still dresses 13 raw controls across 7 therapy files with no shared equivalent", "detail": "CORRECTION 2026-08-21, superseding the update applied earlier the same day: the count of 21 across 8 files recorded by that update was WRONG, and the 13 across 7 files measured by the request cancelled as c6a9756d is RIGHT. The discrepancy flagged in that cancellation is now resolved by direct re-measurement on main rather than by choosing between the two numbers. Cause of the error: the earlier update counted raw textual occurrences of therapyBtn, which includes one import statement per consuming file plus the export in controls.ts, and then compared that total against a baseline expressed in CALL SITES. That is an apples-to-oranges comparison and it overstated the remaining work. Measured per file, excluding the import line in each and excluding the definition: brief-screen 1, compare-screen 1, detail-screen 1, pathways-screen 1, recommend-screen 1, sheets-screen 7, therapy-card 1 = 13 call sites across 7 .tsx files, with the export at controls.ts:26. Against the 30 call sites recorded 2026-08-18 at adf93a75, that is a real reduction of 17, not the 9 the bad arithmetic implied. The design question and the stop rule are unchanged: nothing shared covers list rows, disclosure headers, section toggles and chips, and this must not be resolved by converting the remaining sites to Button variants.", "baseRowFingerprint": "731faf770b9414607177a3e24ae530d98479a5c5f65547da063825563bf711f4" }