As a developer I want to resolve react-hooks/exhaustive-deps warnings so stale closure risks are either fixed or explicitly documented

[ChristopherRotnes]

Summary

Three react-hooks/exhaustive-deps ESLint warnings exist in the codebase. Each is a useEffect that intentionally omits a prop or callback from its dependency array — likely to prevent infinite re-runs on mount-only effects. The warnings are not causing bugs today, but they represent undocumented stale-closure risks. Each location should either be fixed properly (wrap callback in useCallback in the parent) or silenced with an // eslint-disable-next-line comment explaining why the omission is intentional.

Priority

Low — no current user impact; risk surfaces if callbacks change identity between renders.

Acceptance criteria

• History.jsx:204 — initialDate missing from deps: fix or silence with justification comment
• MuscleMap.jsx:165 — onTemplatePreloadConsumed missing from deps: fix or silence with justification comment
• Report.jsx:98 — onPrefillConsumed missing from deps: fix or silence with justification comment
• npm run lint reports 0 react-hooks/exhaustive-deps warnings after the change

Out of scope

• Other lint warning categories (react-refresh, React Compiler violations — tracked separately in As a developer I want to resolve React Compiler violations so the codebase is safe for concurrent rendering and future compiler adoption #160)

[ChristopherRotnes]

Fixed in PR #161. All three locations resolved:

• History.jsx:204 — initialDate captured in a useRef; effect moved after loadSession declaration
• MuscleMap.jsx:165 — onTemplatePreloadConsumed suppressed with comment (re-running on callback identity change would double-dispatch)
• Report.jsx:98 — onPrefillConsumed suppressed with comment (mount-only, one-shot callback)