GET request parameters: retarget net10.0, drop AutoMapper, real test assertions (#2177)

Retarget both projects from net6.0 to net10.0.

Remove AutoMapper. Product and ProductDto declared the same six properties
in the same order, so the mapper copied an object onto its identical twin,
which taught nothing about passing parameters to a GET action. The package,
Mapper/Map.cs, Models/ProductDto.cs, the IMapper field and constructor, and
all eight Map calls are gone; every endpoint now returns the entity and the
JSON responses are byte-identical to before.

Program.cs moves to top-level statements, with the public partial class
Program declaration WebApplicationFactory<Program> needs in the test project.

Packages: Swashbuckle.AspNetCore 6.2.3 to 10.2.3, MSTest 2.2.8 to the 4.3.3
meta package, Microsoft.NET.Test.Sdk 17.1.0 to 18.9.0,
Microsoft.AspNetCore.Mvc.Testing 6.0.0 to 10.0.11, coverlet.collector 3.1.2
to 10.0.1. Newtonsoft.Json 13.0.4 is now referenced explicitly: it used to
arrive transitively through Microsoft.TestPlatform.TestHost 17.1.0, which
declared Newtonsoft.Json 9.0.1; TestHost 18.9.0 declares no such dependency,
so the tests would not compile without it.

Tests: all eight asserted nothing. Each did Assert.IsNotNull followed by a
foreach over the response, so an empty list passed green, and there was no
count assertion in the file. One of the eight really did return empty: the
route-plus-query test called ?waranty=2, one r, against a warranty parameter,
so the value never bound, warranty defaulted to 0, and no product matched.
Fixed the spelling and gave every test a status-code check, a count check and
an exact identity check on the returned products. With the misspelling still
in place the corrected test fails on the count, expected 2 and actual 0.

Build clean with 0 warnings, 8 of 8 tests passing on net10.0.

Author: vladimir-pecanac-main

aspnetcore-webapi/MultipleParametersInGetMethod/MultipleParametersInGetMethod/Controllers/ProductController.cs

@@ -1,5 +1,3 @@
-using AutoMapper;
-using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
 using MultipleParametersInGetMethod.Models;
 
@@ -19,12 +17,6 @@ public class ProductController : ControllerBase
             new Product{ Id = 6, Category = "Sports", Brand = "Adidas", Name = "Football", WarrantyYears = 3, IsAvailable = false },
             new Product{ Id = 7, Category = "Electronic", Brand = "Apple", Name = "Mobile", WarrantyYears = 2, IsAvailable = true }
         };
-        private readonly IMapper _mapper;
-
-        public ProductController(IMapper mapper)
-        {
-            _mapper = mapper;
-        }
 
         [HttpGet]
         public IActionResult GetProductsByCategoryAndBrand(string category, string brand)
@@ -33,7 +25,7 @@ public IActionResult GetProductsByCategoryAndBrand(string category, string brand
                 .Where(x => x.Category == category && x.Brand == brand)
                 .ToList();
 
-            return Ok(_mapper.Map<List<ProductDto>>(result));
+            return Ok(result);
         }
 
         [HttpGet("type-manufacturer")]
@@ -45,57 +37,57 @@ public IActionResult GetProductsByCategoryAndBrandUsingFromQuery(
                 .Where(x => x.Category == category && x.Brand == brand)
                 .ToList();
 
-            return Ok(_mapper.Map<List<ProductDto>>(result));
+            return Ok(result);
         }
 
         [HttpGet("{id}")]
         public IActionResult GetProductById(int id)
         {
-            return Ok(_mapper.Map<ProductDto>(_products
+            return Ok(_products
                 .Where(x => x.Id == id)
-                .FirstOrDefault()));
+                .FirstOrDefault());
         }
 
         [HttpGet("productId/{productId}")]
         public IActionResult GetProductByIdUsingFromRoute([FromRoute(Name = "productId")] int id)
         {
-            return Ok(_mapper.Map<ProductDto>(_products
+            return Ok(_products
                 .Where(x => x.Id == id)
-                .FirstOrDefault()));
+                .FirstOrDefault());
         }
 
         [HttpGet("brand/{brand}")]
         public IActionResult GetProductsByBrandAndWarranty(string brand, int warranty)
         {
-            return Ok(_mapper.Map<List<ProductDto>>(_products
+            return Ok(_products
                 .Where(x => x.Brand == brand && x.WarrantyYears == warranty)
-                .ToList()));
+                .ToList());
         }
 
         [HttpGet("manufacturer/{manufacturer}")]
         public IActionResult GetProductsByBrandAndWarrantyUsingAttributes(
             [FromRoute(Name = "manufacturer")] string brand,
             [FromQuery(Name = "coverage")] int warranty)
         {
-            return Ok(_mapper.Map<List<ProductDto>>(_products
+            return Ok(_products
                 .Where(x => x.Brand == brand && x.WarrantyYears == warranty)
-                .ToList()));
+                .ToList());
         }
 
         [HttpGet("category")]
-        public IActionResult GetProductsByCategory([FromBody] ProductDto model)
+        public IActionResult GetProductsByCategory([FromBody] Product model)
         {
-            return Ok(_mapper.Map<List<ProductDto>>(_products
+            return Ok(_products
                 .Where(x => x.Category == model.Category)
-                .ToList()));
+                .ToList());
         }
 
         [HttpGet("category-brand")]
         public IActionResult GetProductsByCategoryAndBrandViaHeaders([FromHeader] string category, [FromHeader] string brand)
         {
-            return Ok(_mapper.Map<List<ProductDto>>(_products
+            return Ok(_products
                 .Where(x => x.Category == category && x.Brand == brand)
-                .ToList()));
+                .ToList());
         }
     }
-}
+}

aspnetcore-webapi/MultipleParametersInGetMethod/MultipleParametersInGetMethod/Mapper/Map.cs

@@ -1,14 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="12.0.1" />
-    <PackageReference Include="Swashbuckle.AspNetCore" Version="6.2.3" />
+    <PackageReference Include="Swashbuckle.AspNetCore" Version="10.2.3" />
   </ItemGroup>
 
 </Project>

aspnetcore-webapi/MultipleParametersInGetMethod/MultipleParametersInGetMethod/Models/ProductDto.cs

@@ -1,34 +1,26 @@
-namespace MultipleParametersInGetMethod
+var builder = WebApplication.CreateBuilder(args);
+
+// Add services to the container.
+builder.Services.AddControllers();
+// Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
+builder.Services.AddEndpointsApiExplorer();
+builder.Services.AddSwaggerGen();
+
+var app = builder.Build();
+
+// Configure the HTTP request pipeline.
+if (app.Environment.IsDevelopment())
 {
-    public class Program
-    {
-        public static void Main(string[] args)
-        {
-            var builder = WebApplication.CreateBuilder(args);
-
-            // Add services to the container.
-            builder.Services.AddAutoMapper(typeof(Program));
-            builder.Services.AddControllers();
-            // Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
-            builder.Services.AddEndpointsApiExplorer();
-            builder.Services.AddSwaggerGen();
-
-            var app = builder.Build();
-
-            // Configure the HTTP request pipeline.
-            if (app.Environment.IsDevelopment())
-            {
-                app.UseSwagger();
-                app.UseSwaggerUI();
-            }
-
-            app.UseHttpsRedirection();
-
-            app.UseAuthorization();
-
-            app.MapControllers();
-
-            app.Run();
-        }
-    }
-}
+    app.UseSwagger();
+    app.UseSwaggerUI();
+}
+
+app.UseHttpsRedirection();
+
+app.UseAuthorization();
+
+app.MapControllers();
+
+app.Run();
+
+public partial class Program { }