cover ordinal suffix exceptions and edge cases

Author: shirinpanahian

practice-tdd/get-ordinal-number.js

@@ -1,23 +1,13 @@
 export function getOrdinalNumber(num) {
-  if (num % 100 === 11) {
-    throw new Error("Input must not ending with 11");
-  }
-  if (num % 10 === 1) {
+  if (num % 10 === 1 && num % 100 != 11) {
     return `${num}st`;
   }
 
-  if (num % 100 === 22) {
-    throw new Error("Input must not ending with 22");
-  }
-
-  if (num % 10 === 2) {
+  if (num % 10 === 2 && num % 100 != 12) {
     return `${num}nd`;
   }
-  if (num % 100 === 33) {
-    throw new Error("Input must not ending with 33");
-  }
 
-  if (num % 10 === 3) {
+  if (num % 10 === 3 && num % 100 != 13) {
     return `${num}rd`;
   }
 

practice-tdd/get-ordinal-number.test.js

@@ -1,5 +1,4 @@
 import { getOrdinalNumber } from "./get-ordinal-number.js";
-import { test, expect } from "@jest/globals";
 // In this week's prep, we started implementing getOrdinalNumber.
 
 // Continue testing and implementing getOrdinalNumber for additional cases.
@@ -12,13 +11,6 @@ import { test, expect } from "@jest/globals";
 // This approach improves coverage and makes our tests easier to maintain.
 
 // Case 1: Numbers ending with 1 (but not 11)
-test("should not append 'st' for number ending with 11 ", () => {
-  expect(() => getOrdinalNumber(11)).toThrow("Input must not ending with 11");
-  expect(() => getOrdinalNumber(111)).toThrow("Input must not ending with 11");
-  expect(() => getOrdinalNumber(45711)).toThrow(
-    "Input must not ending with 11"
-  );
-});
 
 // When the number ends with 1, except those ending with 11,
 // Then the function should return a string by appending "st" to the number.
@@ -29,42 +21,32 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
   expect(getOrdinalNumber(241)).toEqual("241st");
 });
 
-// Case 2: Numbers ending with 2 (but not 22)
-// When the number ends with 2, except those ending with 22,
+// Case 2: Numbers ending with 2 (but not 12)
+// When the number ends with 2, except those ending with 12,
 // Then the function should return a string by appending "nd" to the number.
-test("should append 'nd' for numbers ending with 2, except those ending with 22", () => {
+test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
   expect(getOrdinalNumber(2)).toEqual("2nd");
+  expect(getOrdinalNumber(22)).toEqual("22nd");
   expect(getOrdinalNumber(32)).toEqual("32nd");
   expect(getOrdinalNumber(132)).toEqual("132nd");
 });
 
-test("should not append 'nd' for number ending with 22 ", () => {
-  expect(() => getOrdinalNumber(22)).toThrow("Input must not ending with 22");
-  expect(() => getOrdinalNumber(122)).toThrow("Input must not ending with 22");
-  expect(() => getOrdinalNumber(45722)).toThrow(
-    "Input must not ending with 22"
-  );
-});
-
-// Case 3: Numbers ending with 3 (but not 33)
-test("should append 'rd' for numbers ending with 3, except those ending with 33", () => {
+// Case 3: Numbers ending with 3 (but not 13)
+test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
   expect(getOrdinalNumber(3)).toEqual("3rd");
-  expect(getOrdinalNumber(13)).toEqual("13rd");
+  expect(getOrdinalNumber(33)).toEqual("33rd");
   expect(getOrdinalNumber(123)).toEqual("123rd");
 });
 
-test("should not append 'rd' for number ending with 33 ", () => {
-  expect(() => getOrdinalNumber(33)).toThrow("Input must not ending with 33");
-  expect(() => getOrdinalNumber(133)).toThrow("Input must not ending with 33");
-  expect(() => getOrdinalNumber(45733)).toThrow(
-    "Input must not ending with 33"
-  );
-});
-
 // Case 3: Numbers ending in other digits
 test("should append 'th' for numbers ending in other digits", () => {
-  expect(getOrdinalNumber(4)).toBe("4th");
+  expect(getOrdinalNumber(11)).toBe("11th");
+  expect(getOrdinalNumber(12)).toBe("12th");
+  expect(getOrdinalNumber(13)).toBe("13th");
   expect(getOrdinalNumber(5)).toBe("5th");
   expect(getOrdinalNumber(10)).toBe("10th");
   expect(getOrdinalNumber(20)).toBe("20th");
+  expect(getOrdinalNumber(111)).toBe("111th");
+  expect(getOrdinalNumber(113)).toBe("113th");
+  expect(getOrdinalNumber(112)).toBe("112th");
 });