Isolate card tests; single previousPasswords test

Author: salahalsabhi

sprint-3-stretch-exercises/card-validator.test.js

@@ -8,7 +8,15 @@ test("should accept another valid 16-digit card number", () => {
   expect(isValidCardNumber("6666666666661666")).toEqual(true);
 });
 
-test("should reject a card number with non-digit characters", () => {
+test("should reject a card number shorter than 16 digits", () => {
+  expect(isValidCardNumber("999999999999998")).toEqual(false);
+});
+
+test("should reject a card number longer than 16 digits", () => {
+  expect(isValidCardNumber("99999999999999998")).toEqual(false);
+});
+
+test("should reject a card number with a non-digit character", () => {
   expect(isValidCardNumber("a92332119c011112")).toEqual(false);
 });
 
@@ -21,13 +29,6 @@ test("should reject a card number whose digits sum to 16 or less", () => {
 });
 
 test("should reject a card number with an odd final digit", () => {
-  expect(isValidCardNumber("6666666666666661")).toEqual(false);
-});
-
-test("should reject a card number shorter than 16 digits", () => {
-  expect(isValidCardNumber("123456789012345")).toEqual(false);
-});
-
-test("should reject a card number longer than 16 digits", () => {
-  expect(isValidCardNumber("12345678901234567")).toEqual(false);
+  // same style as a valid number, only last digit is odd
+  expect(isValidCardNumber("9999777788880001")).toEqual(false);
 });

sprint-3-stretch-exercises/password-validator.test.js

@@ -1,23 +1,18 @@
-/* 
+/*
 Password Validation
-
 Write a program that should check if a password is valid
 and returns a boolean
-
 To be valid, a password must:
 - Have at least 5 characters.
 - Have at least one English uppercase letter (A-Z)
 - Have at least one English lowercase letter (a-z)
 - Have at least one number (0-9)
 - Have at least one of the following non-alphanumeric symbols: ("!", "#", "$", "%", ".", "*", "&")
-- Must not be any previous password in the passwords array. 
-
+- Must not be any previous password in the passwords array.
 You must breakdown this problem in order to solve it. Find one test case first and get that working
 */
 import { isValidPassword } from "./password-validator.js";
 
-const previousPasswords = ["password", "12345", "qwerty"];
-
 test("should accept a password that meets all rules", () => {
   expect(isValidPassword("Abc1!")).toEqual(true);
 });
@@ -43,10 +38,7 @@ test("should reject a password without a required symbol", () => {
   expect(isValidPassword("Abc12")).toEqual(false);
 });
 
-test("should reject a previous password", () => {
-  expect(isValidPassword("password", previousPasswords)).toEqual(false);
-});
-
-test("should reject a password listed in the previousPasswords argument", () => {
+test("should reject a password listed in previousPasswords", () => {
+  // meets all other rules; fails only because it is in the list
   expect(isValidPassword("Abc1!", ["Abc1!"])).toEqual(false);
 });