Skip to content

Fix ConfigurationManager API mismatch: register_config_type vs register_config #353

Description

@jeremymanning

Problem

The test suite for ConfigurationManager expects methods and attributes that don't match the actual implementation:

Tests expect:

  • register_config_type(name, config_class) method
  • _config_types attribute
  • Config type registration and creation workflow

Implementation provides:

  • register_config(name, config_instance) method
  • configurations attribute
  • Config instance storage workflow

Impact

  • Tests in TestConfigurationManager class fail/timeout due to missing methods
  • API inconsistency between test expectations and implementation

Files Affected

  • tests/core/test_wrapper_framework.py (lines 301-340)
  • src/orchestrator/core/wrapper_config.py (ConfigurationManager class)

Solution Options

  1. Update ConfigurationManager to match test expectations
  2. Update tests to match current implementation
  3. Design new unified API that serves both needs

Priority

Medium - affects test coverage but doesn't block core functionality

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions