Skip to content

Central review-process fallback allowlist drift: adversarial_evidence.py missing since #555 extraction #626

Description

@seonghobae

Problem

The central_review_process_fallback_scope allowlist in .github/workflows/opencode-review.yml (fallback_changed_file_allowed(), lines ~1914–1950) does not include:

  • scripts/ci/adversarial_evidence.py
  • tests/test_adversarial_evidence.py

adversarial_evidence.py is central review-process core: it is imported by the allowlisted scripts/ci/opencode_review_normalize_output.py and by scripts/ci/opencode_existing_approval_gate.py, and implements the adversarial-evidence rejection gate used by the approval path.

Root cause (timeline)

Observed impact

PR #618 (changes 6 files: pr-review-merge-scheduler.yml, pr_review_merge_scheduler.py, adversarial_evidence.py + 3 test files) runs with CENTRAL_REVIEW_PROCESS_FALLBACK_ELIGIBLE=false solely because of the two unlisted files — every sibling file in the diff is allowlisted. Evidence: run 30153577309 attempt 11, step "Detect central review-process scope" emits disallowed changed file: scripts/ci/adversarial_evidence.py (and the test twin), so eligible=false.

Scope of impact (verified against the workflow):

Fix direction (minimal)

Add the two entries to fallback_changed_file_allowed() next to the existing opencode_review_normalize_output.py entry:

ContextualWisdomLab/.github:scripts/ci/adversarial_evidence.py | \
ContextualWisdomLab/.github:tests/test_adversarial_evidence.py | \

fallback_changed_file_counts_as_core already treats any allowlisted .github:* path (except .jules/bolt.md) as core, so no second change is needed. Check whether tests/test_opencode_agent_contract.py pins the allowlist contents and update the contract test in the same PR.

Note: any PR carrying this fix is itself merge-blocked until #624 is mitigated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions