feat(auth): add datastore and connection OAuth scopes#569
Open
otorrillas wants to merge 1 commit into
Open
Conversation
Add datastore read/write/manage scopes and connection write scope to the default OAuth login scope set, while keeping read-only login constrained to read scopes. Allow workflow action connection commands to send OAuth bearer tokens now that the connection scopes are requested, and update the command help accordingly.
Member
|
Hey, thanks for this! Getting wider support for newer auth methods (including OAuth) is my main focus, so I'd like to help get this shipped. My comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add OAuth scope registration in pup for Actions Datastore and Action Connections so explicit login scopes and default login scopes can request them.
Changes
Notes
This is the narrow/naive scope-list update. A broader change to how pup handles its growing default OAuth scope set, including potentially omitting scope= for issuer defaults, should be discussed separately.
Testing