feat(dbm): add OAuth support for dbm samples search#570
Merged
platinummonkey merged 3 commits intoJun 8, 2026
Conversation
Adds dbm_read and built_in_features to the OAuth scope list so pup auth login sessions can call the DBM logs analytics endpoint. built_in_features is currently required on US1/EU1; the DBM team is migrating to dbm_read. Requesting both ensures the command works on all sites during the transition.
…n comment - built_in_features was in default_scopes but not read_only_scopes, meaning --read-only mode would fail on US1/EU1 for DBM commands - Add test assertions verifying both scopes are present in read_only_scopes - Extend the migration comment to note when built_in_features can be removed
Default login already requests both required scopes. Naming dbm_read alone was misleading for users on sites that still require built_in_features.
platinummonkey
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #445
Adds
dbm_readandbuilt_in_featuresto the OAuth scope list sopup auth loginsessions can callpup dbm samples search.Why two scopes: the DBM team is migrating permission gating from
built_in_featurestodbm_read. US1/EU1 currently requirebuilt_in_features; the other sites usedbm_read. Requesting both ensures the command works on all sites during the transition.built_in_featurescan be removed once the migration is complete.Also updates the
pup dbm --helpAUTHENTICATION note to reflect OAuth support.Note: the server-side configuration for the
datadog-pup-cliOAuth client already has bothdbm_readandbuilt_in_featuresallowed.Tested end-to-end against...
https://datadoghq.atlassian.net/browse/DAL-647