Skip to content

Commit 1cd29cb

Browse files
jirhikerclaude
andcommitted
Remove dead code: unused imports, functions, classes
Verified via cross-reference (grep + framework-entry-point check) before removal; kept Flask/FastAPI route handlers, click commands, and inherited base-class slots that vulture flags as "unused". Removed: - Dead functions/classes: bounding_polygons get_* helpers (6), geo_utils utm/lonlat converters (+ orphaned PROJECTIONS), converter UnitConverter Protocol, logger Loggable, strategies OutputStrategy, source BaseContainerSource/BaseFileSource, transformer convert_units (deprecated), unifier get_sources_in_polygon/generate_site_bounds/ *_unification_test/get_datastream(s) + stale commented call block. - orchestration/assets/wells.py (build_wells_asset, imported nowhere). - 63 unused imports across backend/frontend/orchestration (autoflake). flake8 (E9,F63,F7,F82) + mypy clean; 427 tests collect with no import errors; local persister tests pass. ckan connector appears entirely unwired (config uses st2 instead) — flagged separately, not removed here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 39a8f4c commit 1cd29cb

30 files changed

Lines changed: 8 additions & 433 deletions

backend/bounding_polygons.py

Lines changed: 0 additions & 99 deletions
Original file line numberDiff line numberDiff line change
@@ -15,113 +15,14 @@
1515
# ===============================================================================
1616
import json
1717
import os
18-
from pprint import pprint
1918

2019
import click
2120
import httpx
22-
from shapely import Polygon, box
2321
from shapely.geometry import shape
2422

2523
from backend.geo_utils import transform_srid, SRID_WGS84, SRID_UTM_ZONE_13N
2624

2725

28-
# polygon retrivial functions
29-
# multiple polygons
30-
def get_congressional_district_boundaries(state, district):
31-
pass
32-
33-
34-
def get_tribal_boundaries(state=None):
35-
state, statefp = _get_statefp(state)
36-
37-
# use the processes service to get all tribal boundaries that intersect the state
38-
def func():
39-
payload = {
40-
"inputs": {
41-
"collection": f"aiannh",
42-
"url": f"https://geoconnex.us/ref/states/{statefp}",
43-
}
44-
}
45-
resp = httpx.post(
46-
"https://reference.geoconnex.us/processes/intersector/execution",
47-
json=payload,
48-
)
49-
return resp.json()
50-
51-
obj = _get_cached_object(f"{state}.aiannh", f"{state} AIANNH", func)
52-
53-
return obj
54-
55-
56-
def get_state_hucs_boundaries(state=None, level=8):
57-
state, statefp = _get_statefp(state)
58-
59-
# use the processes service to get all hucs from this level that intersect the state of NM
60-
def func():
61-
payload = {
62-
"inputs": {
63-
"collection": f"hu{level:02n}",
64-
"url": f"https://geoconnex.us/ref/states/{statefp}",
65-
}
66-
}
67-
resp = httpx.post(
68-
"https://reference.geoconnex.us/processes/intersector/execution",
69-
json=payload,
70-
)
71-
return resp.json()
72-
73-
obj = _get_cached_object(f"{state}.hucs.{level}", f"{state} HU{level:02n}", func)
74-
75-
return obj
76-
77-
78-
def get_state_pwss_boundaries(state=None):
79-
state, statefp = _get_statefp(state)
80-
obj = _get_cached_object(
81-
f"{state}.pws",
82-
f"{state} PWSs",
83-
f"https://reference.geoconnex.us/collections/pws/items?f=json&state_code={state}",
84-
)
85-
86-
return obj
87-
88-
89-
# single polygons
90-
91-
92-
def get_pws_polygon(pwsid, as_wkt=True):
93-
obj = _get_cached_object(
94-
pwsid,
95-
pwsid,
96-
f"https://reference.geoconnex.us/collections/pws/items/{pwsid}?f=json",
97-
)
98-
return _make_shape(obj, as_wkt)
99-
100-
101-
def get_huc_polygon(huc, as_wkt=True):
102-
if len(huc) == 2:
103-
collection = "hu02"
104-
elif len(huc) == 4:
105-
collection = "hu04"
106-
elif len(huc) == 6:
107-
collection = "hu06"
108-
elif len(huc) == 8:
109-
collection = "hu08"
110-
elif len(huc) == 10:
111-
collection = "hu10"
112-
else:
113-
_warning(f"Invalid HUC {huc}. length must be 2, 4, 6, 8, or 10")
114-
return
115-
116-
obj = _get_cached_object(
117-
huc,
118-
huc,
119-
f"https://reference.geoconnex.us/collections/{collection}/items/{huc}?f=json",
120-
)
121-
122-
return _make_shape(obj, as_wkt)
123-
124-
12526
def get_county_polygon(name, as_wkt=True):
12627
if ":" in name:
12728
state, county = name.split(":")

backend/config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import os
1717
import sys
1818
from datetime import datetime, timedelta
19-
from enum import Enum
2019
import shapely.wkt
2120
import yaml
2221

backend/connectors/bor/source.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,7 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
# ===============================================================================
16-
import pprint
17-
from json import JSONDecodeError
1816

19-
import httpx
2017

2118
from backend.connectors.bor.transformer import BORSiteTransformer, BORAnalyteTransformer
2219
from backend.connectors.mappings import BOR_ANALYTE_MAPPING
@@ -27,12 +24,9 @@
2724
SOURCE_PARAMETER_NAME,
2825
SOURCE_PARAMETER_UNITS,
2926
DT_MEASURED,
30-
EARLIEST,
31-
LATEST,
3227
)
3328

3429
from backend.source import (
35-
BaseSource,
3630
BaseSiteSource,
3731
BaseAnalyteSource,
3832
get_terminal_record,

backend/connectors/bor/transformer.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,8 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
# ===============================================================================
16-
import pprint
17-
import json
1816

19-
from backend.record import SiteRecord
2017
from backend.transformer import (
21-
BaseTransformer,
22-
WaterLevelTransformer,
2318
SiteTransformer,
2419
AnalyteTransformer,
2520
)

backend/connectors/ckan/source.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# ===============================================================================
1616
from itertools import groupby
1717

18-
import httpx
1918

2019
from backend.connectors import (
2120
OSE_ROSWELL_HONDO_BOUNDING_POLYGON,
@@ -34,7 +33,6 @@
3433
from backend.constants import (
3534
FEET,
3635
DTW,
37-
DTW_UNITS,
3836
DT_MEASURED,
3937
PARAMETER_NAME,
4038
PARAMETER_UNITS,
@@ -43,7 +41,6 @@
4341
SOURCE_PARAMETER_UNITS,
4442
)
4543
from backend.source import (
46-
BaseSource,
4744
BaseSiteSource,
4845
BaseWaterLevelSource,
4946
get_terminal_record,

backend/connectors/ckan/transformer.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,12 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
# ===============================================================================
16-
import pprint
1716

18-
from backend.record import SiteRecord
19-
from backend.transformer import BaseTransformer, WaterLevelTransformer, SiteTransformer
17+
from backend.transformer import WaterLevelTransformer, SiteTransformer
2018

2119

2220
class OSERoswellSiteTransformer(SiteTransformer):
2321
def _transform(self, record):
24-
# pprint.pprint(record)
2522
lat = float(record["DD_lat"])
2623
lng = float(record["DD_lon"])
2724
# if not self.contained(lng, lat):

backend/connectors/isc_seven_rivers/source.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# ===============================================================================
1616
from datetime import datetime
1717

18-
import httpx
1918

2019
from backend.connectors import ISC_SEVEN_RIVERS_BOUNDING_POLYGON
2120
from backend.connectors.mappings import ISC_SEVEN_RIVERS_ANALYTE_MAPPING
@@ -28,16 +27,13 @@
2827
PARAMETER_UNITS,
2928
SOURCE_PARAMETER_NAME,
3029
SOURCE_PARAMETER_UNITS,
31-
EARLIEST,
32-
LATEST,
3330
)
3431
from backend.connectors.isc_seven_rivers.transformer import (
3532
ISCSevenRiversSiteTransformer,
3633
ISCSevenRiversWaterLevelTransformer,
3734
ISCSevenRiversAnalyteTransformer,
3835
)
3936
from backend.source import (
40-
BaseSource,
4137
BaseSiteSource,
4238
BaseWaterLevelSource,
4339
BaseAnalyteSource,

backend/connectors/isc_seven_rivers/transformer.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,8 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
# ===============================================================================
16-
import shapely.wkt
17-
from shapely import Point
1816

19-
from backend.record import SiteRecord
2017
from backend.transformer import (
21-
BaseTransformer,
2218
WaterLevelTransformer,
2319
SiteTransformer,
2420
AnalyteTransformer,

backend/connectors/nmbgmr/source.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
PARAMETER_VALUE,
3333
SOURCE_PARAMETER_NAME,
3434
SOURCE_PARAMETER_UNITS,
35-
EARLIEST,
36-
LATEST,
3735
)
3836
from backend.source import (
3937
BaseWaterLevelSource,

backend/connectors/nmbgmr/transformer.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,7 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
# ===============================================================================
16-
from backend.constants import DTW
17-
from backend.record import SiteRecord
1816
from backend.transformer import (
19-
BaseTransformer,
2017
WaterLevelTransformer,
2118
SiteTransformer,
2219
AnalyteTransformer,

0 commit comments

Comments
 (0)