feat: update DataReliability test to use lexicon mapper and remove obsolete mapping

Author: jirhiker

tests/test_transfer_legacy_dates.py

@@ -147,8 +147,8 @@ def test_make_location_with_site_date_later_than_date_created(mock_lexicon_mappe
     assert location.nma_site_date == datetime.date(2015, 6, 20)
 
 
-def test_make_location_maps_data_reliability_code():
-    """DataReliability codes should map to lexicon terms."""
+def test_make_location_maps_data_reliability_code(mock_lexicon_mapper):
+    """DataReliability codes should map via the lexicon mapper."""
     row = pd.Series(
         {
             "PointID": "TEST-DR",
@@ -169,10 +169,8 @@ def test_make_location_maps_data_reliability_code():
     )
 
     location, elevation_method, location_notes = make_location(row, {})
-    assert (
-        location.nma_data_reliability
-        == "Data not field checked, but considered reliable"
-    )
+    mock_lexicon_mapper.map_value.assert_called_once_with("LU_DataReliability:U")
+    assert location.nma_data_reliability == mock_lexicon_mapper.map_value.return_value
 
 
 def test_make_location_with_very_old_site_date(mock_lexicon_mapper):

transfers/util.py

@@ -56,13 +56,6 @@
     "T": (10, "second"),
 }
 
-DATA_RELIABILITY_MAP = {
-    "C": "Data field checked by reporting agency",
-    "L": "Location not correct",
-    "M": "Minimal data",
-    "U": "Data not field checked, but considered reliable",
-}
-
 
 class MeasuringPointEstimator:
     def __init__(self):