feat: add lexicon permissions dependencies for editor and admin roles

Author: jirhiker

api/lexicon.py

@@ -30,6 +30,8 @@
     editor_dependency,
     admin_dependency,
     viewer_function,
+    lexicon_editor_dependency,
+    lexicon_admin_dependency,
 )
 from db.lexicon import (
     LexiconCategory,
@@ -58,7 +60,7 @@
 )
 
 router = APIRouter(
-    prefix="/lexicon", tags=["lexicon"], dependencies=[Depends(viewer_function)]
+    prefix="/lexicon", tags=["lexicon"]
 )
 
 
@@ -105,7 +107,7 @@ def database_error_handler(
 async def add_category(
     category_data: CreateLexiconCategory,
     session: session_dependency,
-    user: admin_dependency,
+    user: lexicon_admin_dependency,
 ) -> LexiconCategoryResponse:
     """
     Endpoint to add a category to the lexicon.
@@ -119,7 +121,7 @@ async def add_category(
     status_code=HTTP_201_CREATED,
 )
 async def add_term(
-    term_data: CreateLexiconTerm, session: session_dependency, user: admin_dependency
+    term_data: CreateLexiconTerm, session: session_dependency, user: lexicon_admin_dependency
 ) -> LexiconTermResponse:
     """
     Endpoint to add a term to the lexicon.
@@ -138,7 +140,7 @@ async def add_term(
 async def add_triple(
     triple_data: CreateLexiconTriple,
     session: session_dependency,
-    user: admin_dependency,
+    user: lexicon_admin_dependency,
 ) -> LexiconTripleResponse:
     triple_data = triple_data.model_dump()
     subject = triple_data["subject"]
@@ -155,7 +157,7 @@ async def update_lexicon_term(
     term_id: int,
     term_data: UpdateLexiconTerm,
     session: session_dependency,
-    user: editor_dependency,
+    user: lexicon_editor_dependency,
 ) -> LexiconTermResponse:
 
     return model_patcher(session, LexiconTerm, term_id, term_data, user=user)
@@ -166,7 +168,7 @@ async def update_lexicon_category(
     category_id: int,
     category_data: UpdateLexiconCategory,
     session: session_dependency,
-    user: editor_dependency,
+    user: lexicon_editor_dependency,
 ) -> LexiconCategoryResponse:
     return model_patcher(
         session, LexiconCategory, category_id, category_data, user=user
@@ -178,7 +180,7 @@ async def update_lexicon_triple(
     triple_id: int,
     triple_data: UpdateLexiconTriple,
     session: session_dependency,
-    user: editor_dependency,
+    user: lexicon_editor_dependency,
 ) -> LexiconTripleResponse:
     try:
         return model_patcher(session, LexiconTriple, triple_id, triple_data, user=user)

core/dependencies.py

@@ -15,7 +15,7 @@
 # ===============================================================================
 from typing import Annotated, Callable
 
-from fastapi import Depends
+from fastapi import Depends, HTTPException
 from sqlalchemy.orm import Session
 
 from core.permissions import authenticated
@@ -44,12 +44,27 @@
 # for testing
 no_permission_function = authenticated(permissions=["NoPermission"])
 
+lexicon_editor = authenticated(permissions=["LexiconEditor"])
+lexicon_admin = authenticated(permissions=["LexiconAdmin"])
+def _unauthorized(func):
+    user = func()
+    if not user:
+        raise HTTPException(status_code=401, detail="Unauthorized")
+
+def lexicon_admin_function():
+    return _unauthorized(lexicon_admin)
+
+def lexicon_editor_function():
+    return _unauthorized(lexicon_editor)
+
 
 # permissions dependencies
 admin_dependency = Annotated[Callable, Depends(admin_function)]
 editor_dependency = Annotated[Callable, Depends(editor_function)]
 viewer_dependency = Annotated[Callable, Depends(viewer_function)]
 
+lexicon_admin_dependency = Annotated[Callable, Depends(lexicon_admin_function)]
+lexicon_editor_dependency = Annotated[Callable, Depends(lexicon_editor_function)]
 
 amp_admin_dependency = Annotated[Callable, Depends(amp_admin_function)]
 amp_editor_dependency = Annotated[Callable, Depends(amp_editor_function)]