Skip to content

Commit 9294f43

Browse files
jirhikerclaude
andcommitted
ci: unbind the Dagster deploy from the production environment
The `production` GitHub environment now requires review from the deployers team, with self-review prevented, so applying a data migration to production takes two people. Irreversibility is the reason: a migration that deletes rows has no downgrade, only a restore. That environment is shared, so the gate also covers production API releases, which is intended -- release-please already makes releasing a decision, and this adds one approval to it. It would also have covered the Dagster code location deploy, which is not intended. That job reads only repository-level DAGSTER_CLOUD_API_TOKEN and DAGSTER_CLOUD_ORGANIZATION_ID, none of the environment's secrets, and it runs on every push to staging touching the code location. Binding it would have put an approval gate on routine merges -- a gate on the wrong thing, since it publishes code rather than data. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent fdc59a3 commit 9294f43

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

.github/workflows/CD_dagster_prod.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,13 @@ concurrency:
4747
jobs:
4848
dagster-prod-deploy:
4949
runs-on: ubuntu-latest
50-
environment: production
50+
# Deliberately not bound to the `production` GitHub environment. This job
51+
# reads only repository-level DAGSTER_CLOUD_API_TOKEN and
52+
# DAGSTER_CLOUD_ORGANIZATION_ID -- none of that environment's secrets -- and
53+
# it runs on every push to `staging` that touches the code location. Binding
54+
# it would put an approval gate on routine merges once `production` requires
55+
# reviewers, which is a gate on the wrong thing: this publishes code, not
56+
# data.
5157

5258
steps:
5359
- name: Check out source repository

0 commit comments

Comments
 (0)