Commit 9294f43
ci: unbind the Dagster deploy from the production environment
The `production` GitHub environment now requires review from the deployers
team, with self-review prevented, so applying a data migration to production
takes two people. Irreversibility is the reason: a migration that deletes rows
has no downgrade, only a restore.
That environment is shared, so the gate also covers production API releases,
which is intended -- release-please already makes releasing a decision, and this
adds one approval to it.
It would also have covered the Dagster code location deploy, which is not
intended. That job reads only repository-level DAGSTER_CLOUD_API_TOKEN and
DAGSTER_CLOUD_ORGANIZATION_ID, none of the environment's secrets, and it runs on
every push to staging touching the code location. Binding it would have put an
approval gate on routine merges -- a gate on the wrong thing, since it publishes
code rather than data.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent fdc59a3 commit 9294f43
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
51 | 57 | | |
52 | 58 | | |
53 | 59 | | |
| |||
0 commit comments