refactor: remove geothermal until needed

Author: jacob-a-brown

db/observation.py

@@ -69,13 +69,6 @@ class Observation(Base, AutoBaseMixin, ReleaseMixin):
 
     level_status: Mapped[str] = lexicon_term(nullable=True)
 
-    # geothermal
-    observation_depth: Mapped[float] = mapped_column(
-        nullable=True,
-        info={"unit": "feet"},
-        doc="Depth of the geothermal observation in feet",
-    )
-
     # --- Relationships ---
     # Many-To-One: An Observation can be generated by one piece of Equipment.
     sensor: Mapped["Sensor"] = relationship(  # noqa: F821

tests/test_observation.py

@@ -106,35 +106,6 @@ def test_add_groundwater_level_observation(groundwater_level_sample, sensor):
     cleanup_post_test(Observation, data["id"])
 
 
-# def test_add_geothermal_observation(geothermal_sample, sensor):
-#     payload = {
-#         "observation_datetime": "2025-01-01T00:00:00Z",
-#         "release_status": "draft",
-#         "observation_depth": 100,
-#         "value": 25.5,
-#         "sample_id": geothermal_sample.id,
-#         "sensor_id": sensor.id,
-#         "observed_property": "temperature",
-#         "unit": "deg C",
-#     }
-#     response = client.post("/observation/geothermal", json=payload)
-#     data = response.json()
-#     assert response.status_code == 201
-
-#     assert "id" in data
-#     assert "created_at" in data
-#     assert data["observation_datetime"] == payload["observation_datetime"]
-#     assert data["release_status"] == payload["release_status"]
-#     assert data["observation_depth"] == payload["observation_depth"]
-#     assert data["value"] == payload["value"]
-#     assert data["sample_id"] == payload["sample_id"]
-#     assert data["sensor_id"] == payload["sensor_id"]
-#     assert data["observed_property"] == payload["observed_property"]
-#     assert data["unit"] == payload["unit"]
-
-#     cleanup_post_test(Observation, data["id"])
-
-
 # PATCH tests ==================================================================
 
 
@@ -224,48 +195,6 @@ def test_patch_water_chemistry_observation_404_wrong_activity_type(
     )
 
 
-# def test_patch_geothermal_observation(geothermal_observation):
-#     payload = {"observation_depth": 4, "release_status": "private"}
-#     response = client.patch(
-#         f"/observation/geothermal/{geothermal_observation.id}", json=payload
-#     )
-#     assert response.status_code == 200
-#     data = response.json()
-#     assert data["observation_depth"] == payload["observation_depth"]
-#     assert data["release_status"] == payload["release_status"]
-
-#     cleanup_patch_test(Observation, payload, geothermal_observation)
-
-
-# def test_patch_geothermal_observation_404_not_found(geothermal_observation):
-#     bad_id = 999999
-#     payload = {"observation_depth": 8}
-#     response = client.patch(f"/observation/geothermal/{bad_id}", json=payload)
-#     assert response.status_code == 404
-#     data = response.json()
-#     assert data["detail"] == f"Observation with ID {bad_id} not found."
-
-
-# def test_patch_geothermal_observation_404_wrong_activity_type(
-#     groundwater_level_observation, water_chemistry_observation
-# ):
-#     for obs in groundwater_level_observation, water_chemistry_observation:
-#         payload = {"value": 8}
-#         response = client.patch(f"/observation/geothermal/{obs.id}", json=payload)
-#         assert response.status_code == 404
-#         data = response.json()
-
-#         if obs.observed_property == "groundwater level":
-#             activity_type = "groundwater level"
-#         else:
-#             activity_type = "water chemistry"
-
-#         assert (
-#             data["detail"][0]["msg"]
-#             == f"Observation with ID {obs.id} is not a geothermal observation. It is a {activity_type} observation."
-#         )
-
-
 # ============= Get tests =================
 
 
@@ -592,87 +521,6 @@ def test_get_water_chemistry_observation_by_id_404_wrong_activity_type(
     assert data["detail"][0]["loc"] == ["path", "observation_id"]
 
 
-# def test_get_geothermal_observations(geothermal_observation):
-#     response = client.get("/observation/geothermal")
-#     assert response.status_code == 200
-#     data = response.json()
-#     assert data["total"] == 1
-#     assert data["items"][0]["id"] == geothermal_observation.id
-#     assert data["items"][0][
-#         "created_at"
-#     ] == geothermal_observation.created_at.isoformat().replace("+00:00", "Z")
-#     assert data["items"][0]["release_status"] == geothermal_observation.release_status
-#     assert data["items"][0]["sample_id"] == geothermal_observation.sample_id
-#     assert data["items"][0]["sensor_id"] == geothermal_observation.sensor_id
-#     assert (
-#         data["items"][0]["observation_datetime"]
-#         == geothermal_observation.observation_datetime
-#     )
-#     colon_index = geothermal_observation.observed_property.find(":")
-#     assert (
-#         data["items"][0]["observed_property"]
-#         == geothermal_observation.observed_property[colon_index + 1 :]
-#     )
-#     assert data["items"][0]["value"] == geothermal_observation.value
-#     assert data["items"][0]["unit"] == geothermal_observation.unit
-#     assert (
-#         data["items"][0]["observation_depth"]
-#         == geothermal_observation.observation_depth
-#     )
-
-
-# def test_get_geothermal_observation_by_id(geothermal_observation):
-#     response = client.get(f"/observation/geothermal/{geothermal_observation.id}")
-#     assert response.status_code == 200
-#     data = response.json()
-#     assert data["id"] == geothermal_observation.id
-#     assert data["created_at"] == geothermal_observation.created_at.isoformat().replace(
-#         "+00:00", "Z"
-#     )
-#     assert data["release_status"] == geothermal_observation.release_status
-#     assert data["sample_id"] == geothermal_observation.sample_id
-#     assert data["sensor_id"] == geothermal_observation.sensor_id
-#     assert data["observation_datetime"] == geothermal_observation.observation_datetime
-#     colon_index = geothermal_observation.observed_property.find(":")
-#     assert (
-#         data["observed_property"]
-#         == geothermal_observation.observed_property[colon_index + 1 :]
-#     )
-#     assert data["value"] == geothermal_observation.value
-#     assert data["unit"] == geothermal_observation.unit
-#     assert data["observation_depth"] == geothermal_observation.observation_depth
-
-
-# def test_get_geothermal_observation_by_id_404_not_found(geothermal_observation):
-#     bad_id = 99999
-#     response = client.get(f"/observation/geothermal/{bad_id}")
-#     assert response.status_code == 404
-#     data = response.json()
-#     assert data["detail"] == f"Observation with ID {bad_id} not found."
-
-
-# def test_get_geothermal_observation_by_id_404_wrong_activity_type(
-#     water_chemistry_observation, groundwater_level_observation
-# ):
-#     for obs in water_chemistry_observation, groundwater_level_observation:
-#         response = client.get(f"/observation/geothermal/{obs.id}")
-#         assert response.status_code == 404
-#         data = response.json()
-
-#         if obs.observed_property == "groundwater level":
-#             actual_activity_type = "groundwater level"
-#         else:
-#             actual_activity_type = "water chemistry"
-
-#         assert (
-#             data["detail"][0]["msg"]
-#             == f"Observation with ID {obs.id} is not a geothermal observation. It is a {actual_activity_type} observation."
-#         )
-#         assert data["detail"][0]["type"] == "value_error"
-#         assert data["detail"][0]["input"] == {"observation_id": obs.id}
-#         assert data["detail"][0]["loc"] == ["path", "observation_id"]
-
-
 # JB's comment: I don't think that geographic filters are necessary for
 # observations. I think that they should only be applicable to finding Things
 # and locations. Then the user can proceed from there to find observations.