Render: honor invalid variant entries (invalid: true)

[nathanacurtis]

Remaining work

Variant entries flagged invalid: true (partial configurations) are treated as blanket exclusion rules. When they collapse the combination matrix to a single survivor, Component.write() takes the single-COMPONENT branch — no ComponentSet is created, no VARIANT properties are minted, and the round-tripped spec shows props: {} and nodeType: COMPONENT.

Approach

Branch on "spec has variant-typed props", not "more than one combination survived": figma.combineAsVariants([node], page) accepts a single element and still yields a COMPONENT_SET with real VARIANT property definitions.

Known ceiling

Figma derives variantOptions from actual sibling values — declared-but-unused enum options are unrecoverable when filtering collapses the matrix. nodeType and props presence are fixable; full enum breadth is not.

Affected fixtures

testInvalidVariants (also check testVariantsMissing1/2 for the same branch trap)

Where (code)

• Branch trap: specs-from-figma/packages/figma-from-specs/src/Component.ts (write(), the resolved.length === 1 single-COMPONENT branch)
• Exclusion filtering: src/Variants/Variants.ts (resolve(), invalidRules + isSubset)
• Variant prop detection for the new condition: src/Props/Props.ts (isVariant)

Shared verification loop and working context: see parent #208.

Additional impacted fixture: testGradientStrokes (declares both invalid variants and invalidCombinations; its round-trip diff shows whole variant entries missing — 43 lines — after all #261 gradient math was fixed).

[nathanacurtis]

Fixed in specs-from-figma 3e2eed4 on feat/figma-from-specs.

Root cause — not the resolved.length === 1 branch trap this issue points at. Variants.resolve() treated a variant entry's invalid: true configuration as a partial subset rule, identically to an invalidVariantCombinations entry. The two constructs differ:

• A variant entry's configuration comes from the reader's nonDefaultConfigurations() — always one whole combination with its default-valued props elided. { a: A3 } where b defaults to B1 names a=A3,b=B1 only.
• invalidVariantCombinations entries name prop values that can never co-occur, so they stay subset rules — { disabled: true, state: hover } excludes every expansion of that pairing.

Subset-matching the former collapsed the matrix and dropped combinations the generator itself considers valid, which is what drove the single-survivor branch into COMPONENT.

Verification — render round-trip against testVariantsMissing1/2. The read-back invalidVariantCombinations is byte-identical to the baseline (6 of 8 combinations rendered, missing exactly A3/B1 and A4/B2), nodeType stays COMPONENT_SET, and the valid variant entries match in content and order. 10 unit cases added in tests/unit/Variants/Variants.test.ts.

Not covered:

• The resolved.length === 1 branch condition in Component.ts is unchanged. This fix makes it far less reachable but does not eliminate it — a spec whose exclusions genuinely collapse to one survivor still produces a plain COMPONENT with no variant props.
• Round-trip variant frame names are minted from format-key-formatted prop names, so a Figma property named A renders back as a (visible as anatomy.*.detectedIn drift). Same unrecoverable class as the enum-breadth ceiling noted in Render: honor invalid variant entries (invalid: true) #271.
• testInvalidVariants and testGradientStrokes were not re-run.