fix(security): encode Address widget Places proxy query parameters#2265
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(security): encode Address widget Places proxy query parameters#2265cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
User-controlled autocomplete input was interpolated into a raw URL string, allowing attackers to inject extra query parameters (for example to override country filters). Build proxy URLs with Uri.https and add regression tests. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability summary
The Address widget built Google Places autocomplete proxy URLs by interpolating user search text into a raw query string. A user (or anyone who can type into the field) could inject additional
&key=valuepairs — for example overriding the app'scountryFilterrestriction.Affected location
modules/ensemble/lib/widget/address.dart(_getSearchResults,_getPlaceDetail)modules/ensemble/lib/widget/address_url_builder.dartSecurity impact
Severity: Medium
foo&components=country:US)AddressState._getSearchResults()built URLs via string concatenationFix approach
Build proxy URLs with
Uri.httpsandqueryParametersso user input is percent-encoded.Tests
modules/ensemble/test/address_url_security_test.dart