Skip to content

ppt-codec: reader-gated writer drops, rotation, insets, and the throw-vs-drop alignment #1188

Description

@Mearman

The writer silently drops images, tables, and OLE shapes because the reader reads them as empty shapes -- writing them first needs the read side (images via the blip store the reader walks past, tables, OLE objects). rotationDeg has no [MS-PPT] spelling this package has confirmed (getter-only in the editor); per-shape insets are never stated (the reader reports defaults); strike has no bit at all.

Separately, doc-codec throws for an unwritable block while ppt-codec drops what its reader also skips. Flipping ppt to throw changes every documents.js pdf-to-ppt / odp-to-ppt conversion carrying images -- a deliberate behaviour change flagged on #971's scorecard rather than made inside a scope PR.

Evidence

#971 scorecard; ppt-codec README; documents.js src/edit/ppt/slide.ts rotationDeg comment.

Affected packages: ppt-codec, documents.js

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions