From 8b051c2c43fc11d51e0dbe45e8ff5cda973bea94 Mon Sep 17 00:00:00 2001 From: Joseph Mearman Date: Thu, 10 Sep 2026 07:13:32 +0100 Subject: [PATCH] ci: read the Node version from .tool-versions instead of two hardcoded values cddl-validate and conformance-verify each hardcoded their own Node version ('22' and '26'), an inconsistency with no single source of truth. actions/setup-node's node-version-file now reads .tool-versions for both jobs, matching the pattern agent-comms already uses. --- .github/workflows/ci.yml | 4 ++-- .tool-versions | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 .tool-versions diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8abd546..38cd665 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: '22' + node-version-file: .tool-versions - name: Regenerate protocol.cddl and confirm it matches the committed file working-directory: spec @@ -73,7 +73,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: '26' + node-version-file: .tool-versions cache: pnpm cache-dependency-path: conformance/pnpm-lock.yaml diff --git a/.tool-versions b/.tool-versions new file mode 100644 index 0000000..d0b4db8 --- /dev/null +++ b/.tool-versions @@ -0,0 +1 @@ +nodejs 26