Scan - Split details page does not show the new UI when scan expense is split offline - #102799
Open
thelullabyy wants to merge 1 commit into
Open
thelullabyy wants to merge 1 commit into
thelullabyy wants to merge 1 commit into
Conversation
thelullabyy
changed the title
thelullabyy
marked this pull request as ready for review
October 1, 2026 18:38
melvin-bot
Bot
requested review from
ikevin127 and
trjExpensify
and removed request for
a team
October 1, 2026 18:38
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-10-01.at.16.54.25.mov |
ikevin127
reviewed
Oct 1, 2026
| receipt: { | ||
| state: CONST.IOU.RECEIPT_STATE.OPEN, | ||
| }, | ||
| iouRequestType: CONST.IOU.REQUEST_TYPE.MANUAL, |
Contributor
There was a problem hiding this comment.
src/libs/actions/IOU/Split.ts:951
🟢 Could we add a short comment here explaining why ? It's not obvious from the code alone why completing a split flips the type. Without context, someone could later "clean up" this line and quietly bring back #102491.
Something like:
receipt: {
state: CONST.IOU.RECEIPT_STATE.OPEN,
},
// The user filled the fields in by hand, so the receipt is no longer scanned. Mirror what the server returns
// so the split details page renders the manual layout while offline instead of waiting for the response.
iouRequestType: CONST.IOU.REQUEST_TYPE.MANUAL,
ikevin127
reviewed
Oct 1, 2026
| splitTransaction = await getOnyxValue(`${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransactionID}`); | ||
| expect(splitTransaction?.iouRequestType).toBe(CONST.IOU.REQUEST_TYPE.MANUAL); | ||
|
|
||
| mockFetch?.resume?.(); |
Contributor
There was a problem hiding this comment.
tests/actions/IOUTest/SplitTest.ts:1334
🟢 The fix depends on failureData spreading ...unmodifiedTransaction to put iouRequestType: SCAN back if CompleteSplitBill fails. Right now nothing tests that path.
Can we fail the request here and check that it rolls back ? Then a future change to failureData (for example, narrowing the spread to a few fields) can't leave a failed split stuck in the manual layout with an RBR:
mockFetch?.fail?.();
await mockFetch?.resume?.();
await waitForBatchedUpdates();
// Then the split goes back to being a scan request so the user can retry from the original state
splitTransaction = await getOnyxValue(`${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransactionID}`);
expect(splitTransaction?.iouRequestType).toBe(CONST.IOU.REQUEST_TYPE.SCAN);
expect(splitTransaction?.errors).toBeTruthy();(This also awaits resume() the way the other tests in this file do.)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #102491
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-02.at.02.34.58.mov