From 5ac6c8a7e317785dcb09819f68b5cf7839fe2f36 Mon Sep 17 00:00:00 2001
From: PJ Fanning <pjfanning@users.noreply.github.com>
Date: Wed, 9 Sep 2026 10:32:03 +0100
Subject: [PATCH] (jsr-353) Re-enable test suite by running tests from class
 path

Tests were disabled in 18-Jan-2025 because the JSON-P 1.1 RI
(`org.glassfish:javax.json`) declares Automatic-Module-Name "java.json" -- the
same name as the API module (`javax.json:javax.json-api`) -- so the two cannot
both be read on the module path:

    javax.json.JsonException: Provider org.glassfish.json.JsonProviderImpl not found

The module name only matters on the module path, so tell surefire to run from
the class path instead (`useModulePath=false`) and restore the test-scoped RI
dependency. Main sources are still compiled on the module path, so the
`module-info.java` `requires java.json` is still validated.

This brings back 26 tests that have not run since Jan 2025 -- including
`JsonPatchDeserializationTest` and `ModuleSPIMetadataTest`. All pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 jsr-353/pom.xml | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/jsr-353/pom.xml b/jsr-353/pom.xml
index 63bd0e1..0dde6b2 100644
--- a/jsr-353/pom.xml
+++ b/jsr-353/pom.xml
@@ -38,28 +38,30 @@ working with JSR-353 (JSON-P) node types via data-binding
     <!-- 18-Jan-2025, tatu: Except, not with JPMS because that PoS component
        decided to use Automatic Module Name of "java.json". Which it absolutely
        cannot, being the _API_ module.
-       So. We cannot really run tests any more. And with deprecation by Jakarta JSONP
-       we may want to remove the module. But for now drop dep
+       09-Sep-2026, pjfanning: worked around by running tests from class path
+       (see `useModulePath` below), so the clashing module name is never read.
+      -->
     <dependency>
         <groupId>org.glassfish</groupId>
         <artifactId>javax.json</artifactId>
         <version>1.1.4</version>
         <scope>test</scope>
     </dependency>
-      -->
 
   </dependencies>
 
   <build>
     <plugins>
-      <!-- 18-Jan-2025, tatu: As per above, we cannot really run tests with JPMS.
-              So. Disable surefire plug-in altogether
+      <!-- 09-Sep-2026, pjfanning: The JSON-P 1.1 RI declares Automatic-Module-Name
+              "java.json", the same name as the API module, so the two cannot both be
+              read on the module path. Run tests from the class path instead, where
+              module names are not used: that lets the suite run again.
         -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
-          <skipTests>true</skipTests>
+          <useModulePath>false</useModulePath>
         </configuration>
       </plugin>
       <plugin>