From f99e0bd3946ed03efb96966e30286962a197a38c Mon Sep 17 00:00:00 2001 From: MelchiorSchuh Date: Tue, 25 Aug 2026 17:41:44 +0200 Subject: [PATCH 1/2] fix(Output): Removed output of non transferable attributes --- include/geode/io/image/detail/vtk_output.hpp | 3 ++- tests/model/test-vtm.cpp | 16 +++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/include/geode/io/image/detail/vtk_output.hpp b/include/geode/io/image/detail/vtk_output.hpp index 244cfca..72c42e3 100644 --- a/include/geode/io/image/detail/vtk_output.hpp +++ b/include/geode/io/image/detail/vtk_output.hpp @@ -86,7 +86,8 @@ namespace geode for( const auto& id : manager.attribute_ids() ) { const auto attribute = manager.find_generic_attribute( id ); - if( !attribute || !attribute->is_genericable() ) + if( !attribute || !attribute->is_genericable() + || !attribute->properties().transferable ) { continue; } diff --git a/tests/model/test-vtm.cpp b/tests/model/test-vtm.cpp index df1cd93..04e1dc9 100644 --- a/tests/model/test-vtm.cpp +++ b/tests/model/test-vtm.cpp @@ -43,14 +43,16 @@ int main() geode::OpenGeodeIOMeshLibrary::initialize(); geode::OpenGeodeIOModelLibrary::initialize(); - auto brep = - geode::load_brep( absl::StrCat( geode::DATA_PATH, "mss.og_brep" ) ); - const auto filename = absl::StrCat( "mss.vtm" ); + auto brep = geode::load_brep( "native.og_brep" ); + // auto brep = + // geode::load_brep( absl::StrCat( geode::DATA_PATH, "mss.og_brep" ) + // ); + const auto filename = absl::StrCat( "native.vtm" ); geode::save_brep( brep, filename ); - auto section = geode::load_section( - absl::StrCat( geode::DATA_PATH, "mss_cut_section.og_sctn" ) ); - const auto filename2 = absl::StrCat( "mss_cut_section.vtm" ); - geode::save_section( section, filename2 ); + // auto section = geode::load_section( + // absl::StrCat( geode::DATA_PATH, "mss_cut_section.og_sctn" ) ); + // const auto filename2 = absl::StrCat( "mss_cut_section.vtm" ); + // geode::save_section( section, filename2 ); geode::Logger::info( "TEST SUCCESS" ); return 0; From 7fdeff6482c42e952d10a19907038e4dee6f75b1 Mon Sep 17 00:00:00 2001 From: BenPinet Date: Wed, 26 Aug 2026 09:09:57 +0200 Subject: [PATCH 2/2] fix test --- tests/model/test-vtm.cpp | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tests/model/test-vtm.cpp b/tests/model/test-vtm.cpp index 04e1dc9..2a64b7f 100644 --- a/tests/model/test-vtm.cpp +++ b/tests/model/test-vtm.cpp @@ -43,17 +43,14 @@ int main() geode::OpenGeodeIOMeshLibrary::initialize(); geode::OpenGeodeIOModelLibrary::initialize(); - auto brep = geode::load_brep( "native.og_brep" ); - // auto brep = - // geode::load_brep( absl::StrCat( geode::DATA_PATH, "mss.og_brep" ) - // ); - const auto filename = absl::StrCat( "native.vtm" ); + auto brep = + geode::load_brep( absl::StrCat( geode::DATA_PATH, "mss.og_brep" ) ); + const auto filename = absl::StrCat( "mss.vtm" ); geode::save_brep( brep, filename ); - // auto section = geode::load_section( - // absl::StrCat( geode::DATA_PATH, "mss_cut_section.og_sctn" ) ); - // const auto filename2 = absl::StrCat( "mss_cut_section.vtm" ); - // geode::save_section( section, filename2 ); - + auto section = geode::load_section( + absl::StrCat( geode::DATA_PATH, "mss_cut_section.og_sctn" ) ); + const auto filename2 = absl::StrCat( "mss_cut_section.vtm" ); + geode::save_section( section, filename2 ); geode::Logger::info( "TEST SUCCESS" ); return 0; }