refactor: simplify rho symbol rebrand runtime

Author: Patel230

cmd/chat.go

@@ -42,6 +42,7 @@ import (
 	rhostorage "github.com/GrayCodeAI/rho/internal/storage"
 	"github.com/GrayCodeAI/rho/internal/system/staleness"
 	"github.com/GrayCodeAI/rho/internal/tool"
+	"github.com/GrayCodeAI/rho/internal/tui"
 	"github.com/GrayCodeAI/rho/internal/ui/icons"
 )
 
@@ -330,6 +331,9 @@ func newChatModelWithRegistry(ref *progRef, systemPrompt string, settings rhocon
 		Enabled:        true,
 		MaxAutoApprove: safety.AutonomySemi,
 		ConfirmFn: func(req engine.ApprovalRequest) engine.ApprovalResponse {
+			if sess.PermSvc() != nil && sess.PermSvc().RuntimeState().Autonomy == safety.AutonomyYOLO {
+				return engine.ApprovalApprove
+			}
 			response := make(chan engine.ApprovalResponse, 1)
 			ref.Send(approvalAskMsg{req: req, response: response})
 			select {
@@ -528,11 +532,11 @@ func (m *chatModel) refreshInputPlaceholder() {
 	}
 	switch work {
 	case engine.WorkModePlan:
-		m.input.Placeholder = "Design architecture or draft plan...  ·  / commands  ·  ? help"
+		m.input.Placeholder = "Design architecture or draft plan...  ·  /select copy  ·  ? help"
 	case engine.WorkModeReview:
-		m.input.Placeholder = "Audit diffs, security, or PRs...  ·  / commands  ·  ? help"
+		m.input.Placeholder = "Audit diffs, security, or PRs...  ·  /select copy  ·  ? help"
 	default:
-		m.input.Placeholder = "Build, refactor, or run commands...  ·  / commands  ·  ? help"
+		m.input.Placeholder = "Build, refactor, or run commands...  ·  /select copy  ·  ? help"
 	}
 }
 
@@ -726,16 +730,24 @@ func runChat() error {
 
 	finalModel, err := p.Run()
 	writeTerminalMouse(disableMouseCSI)
+	// Kitty graphics are not scoped to Bubble Tea's alternate screen. Remove
+	// the optional welcome mascot before the farewell is written so shutdown
+	// leaves only the final text message in the terminal.
+	_ = tui.ClearGraphics(os.Stderr)
 	if err != nil {
 		return err
 	}
-	fm, ok := finalModel.(chatModel)
-	if !ok {
-		return fmt.Errorf("unexpected final model type: %T", finalModel)
+	fm, err := finalChatModel(finalModel)
+	if err != nil {
+		return err
 	}
 	if fm.quitting {
 		fm.saveSession()
-		fmt.Print(formatQuitResumeMessage(fm.sessionID))
+		// Bubble Tea restores the previous screen before returning. Clear that
+		// frame and any terminal-persistent mascot so shutdown has one clean,
+		// predictable final state.
+		fmt.Print("\x1b[2J\x1b[H")
+		fmt.Println("Thank you for using Rho!")
 		return nil
 	}
 	rhoC := ansiOrange
@@ -790,3 +802,18 @@ func runChat() error {
 	}
 	return nil
 }
+
+// finalChatModel normalizes Bubble Tea's shutdown model. Bubble Tea may return
+// either the value passed to NewProgram or its pointer after updates; both are
+// valid representations of the same chat state.
+func finalChatModel(model tea.Model) (chatModel, error) {
+	switch m := model.(type) {
+	case chatModel:
+		return m, nil
+	case *chatModel:
+		if m != nil {
+			return *m, nil
+		}
+	}
+	return chatModel{}, fmt.Errorf("unexpected final model type: %T", model)
+}

cmd/chat_runtime_test.go

@@ -0,0 +1,42 @@
+package cmd
+
+import (
+	"strings"
+	"testing"
+
+	tea "charm.land/bubbletea/v2"
+)
+
+type unexpectedFinalChatModel struct{}
+
+func (unexpectedFinalChatModel) Init() tea.Cmd { return nil }
+
+func (m unexpectedFinalChatModel) Update(tea.Msg) (tea.Model, tea.Cmd) { return m, nil }
+
+func (unexpectedFinalChatModel) View() tea.View { return tea.View{} }
+
+func TestFinalChatModelAcceptsValueAndPointer(t *testing.T) {
+	want := chatModel{sessionID: "session-1", quitting: true}
+
+	for name, input := range map[string]tea.Model{
+		"value":   want,
+		"pointer": &want,
+	} {
+		t.Run(name, func(t *testing.T) {
+			got, err := finalChatModel(input)
+			if err != nil {
+				t.Fatalf("finalChatModel() error = %v", err)
+			}
+			if got.sessionID != want.sessionID || got.quitting != want.quitting {
+				t.Fatalf("finalChatModel() = %+v, want %+v", got, want)
+			}
+		})
+	}
+}
+
+func TestFinalChatModelRejectsUnexpectedModel(t *testing.T) {
+	_, err := finalChatModel(unexpectedFinalChatModel{})
+	if err == nil || !strings.Contains(err.Error(), "unexpected final model type") {
+		t.Fatalf("finalChatModel() error = %v, want unexpected model error", err)
+	}
+}

cmd/chat_scrollbar.go

@@ -50,9 +50,6 @@ func (m chatModel) chatViewportWidth(totalWidth int) int {
 	if totalWidth <= 0 {
 		return 0
 	}
-	if mainWidth := m.chatMainWidth(totalWidth); mainWidth != totalWidth {
-		totalWidth = mainWidth
-	}
 	if m.chatHasOverflow() && totalWidth > scrollbarWidth {
 		return totalWidth - scrollbarWidth
 	}
@@ -171,13 +168,13 @@ func (m chatModel) renderChatPane() string {
 
 	if !m.chatScrollbarVisible() {
 		chatView = padToHeight(chatView, origVpH)
-		return m.joinChatSidebar(chatView, origVpH)
+		return chatView
 	}
 
 	scrollbar := m.renderScrollbarHeight(origVpH)
 	if scrollbar == "" {
 		chatView = padToHeight(chatView, origVpH)
-		return m.joinChatSidebar(chatView, origVpH)
+		return chatView
 	}
 
 	targetW := m.viewport.Width()
@@ -205,33 +202,5 @@ func (m chatModel) renderChatPane() string {
 			out.WriteByte('\n')
 		}
 	}
-	return m.joinChatSidebar(out.String(), origVpH)
-}
-
-func (m chatModel) joinChatSidebar(chatView string, height int) string {
-	sidebarW := m.chatSidebarWidth(m.width)
-	if sidebarW == 0 {
-		return chatView
-	}
-	mainW := m.viewport.Width()
-	if mainW <= 0 {
-		mainW = m.chatMainWidth(m.width)
-	}
-	lines := strings.Split(padToHeight(chatView, height), "\n")
-	sidebar := strings.Split(m.renderSessionSidebar(sidebarW, height), "\n")
-	divider := scrollbarTrackStyle().Render("│")
-	var out strings.Builder
-	for i := 0; i < height; i++ {
-		if i > 0 {
-			out.WriteByte('\n')
-		}
-		line := lines[i]
-		if w := visibleWidth(line); w < mainW {
-			line += strings.Repeat(" ", mainW-w)
-		}
-		out.WriteString(line)
-		out.WriteString(divider)
-		out.WriteString(sidebar[i])
-	}
 	return out.String()
 }

cmd/chat_scrollbar_test.go

@@ -60,6 +60,23 @@ func TestChatViewportWidth_NarrowTerminalClampsWithoutJump(t *testing.T) {
 	}
 }
 
+func TestRenderChatPaneUsesFullWidthWithoutSessionSidebar(t *testing.T) {
+	m := chatModel{
+		viewport:     viewportWithSize(120, 4),
+		contentLines: 2,
+		width:        120,
+	}
+	m.viewport.SetContent("hello\nworld")
+
+	got := m.renderChatPane()
+	if strings.Contains(got, "SESSION") || strings.Contains(got, "CONTEXT") {
+		t.Fatalf("chat pane still renders the removed session sidebar: %q", got)
+	}
+	if !strings.Contains(got, "hello") || !strings.Contains(got, "world") {
+		t.Fatalf("chat pane lost conversation content: %q", got)
+	}
+}
+
 func TestRenderScrollbar_TopAndBottom(t *testing.T) {
 	m := chatModel{
 		viewport:     viewportWithSize(80, 10),

cmd/chat_sidebar.go

@@ -820,6 +820,17 @@ func init() {
 		},
 	})
 
+	// /permission — focused control plane for access decisions and folder trust.
+	subcommandRegistry.Register(&delegatingCommand{
+		name:        "permission",
+		description: "show or change permissions and folder trust",
+		usage:       "/permission [status|trust|reset]",
+		handler: func(m *chatModel, args []string, text string) (tea.Model, tea.Cmd) {
+			next, cmd := m.handlePolicyCommand(args)
+			return &next, cmd
+		},
+	})
+
 	// /add <file...> — add file content to context
 	subcommandRegistry.Register(&delegatingCommand{
 		name:        "add",