feat: derive provider count from eyrie registry; drop legacy credential naming

- RegisteredProviderCount() now returns eyrieengine.RegisteredGatewayCount()
  instead of a hard-coded 27, so adding a provider in eyrie needs no hawk
  changes
- Rename MigrateLegacyCredentials -> MigrateEnvFileCredentials across
  gateway, hawkconfig, and the credentials migrate command
- migrateStoredModelProvider / plaintextCredentialFilesPresent renames;
  manpage + gateway-count tests derive expectations from the registry
- Bump external/eyrie to feat/typed-provider-credentials (registry-driven
  credential mapping)
- Hermeticize TestFormatModelThinkingCell (real user settings were leaking
  per-model thinking preferences into the assertion)

Author: Patel230

cmd/credentials.go

@@ -41,21 +41,21 @@ var credentialsRemoveCmd = &cobra.Command{
 
 var credentialsMigrateCmd = &cobra.Command{
 	Use:   "migrate",
-	Short: "Import legacy plaintext credential files into the OS secret store",
+	Short: "Import plaintext credential files into the OS secret store",
 	RunE: func(cmd *cobra.Command, args []string) error {
 		ctx := context.Background()
 		storage := hawkconfig.CredentialStorageStatus(ctx)
 		if !storage.Writable {
 			return fmt.Errorf("cannot migrate: %s", storage.Detail)
 		}
-		n, err := hawkconfig.MigrateLegacyCredentials(ctx)
+		n, err := hawkconfig.MigrateEnvFileCredentials(ctx)
 		if err != nil {
 			return err
 		}
 		if n == 0 {
-			cmd.Println("No legacy credential files found (already using secure storage).")
+			cmd.Println("No plaintext credential files found (already using secure storage).")
 		} else {
-			cmd.Printf("Migrated %d key(s) to %s and removed legacy credential files.\n", n, hawkconfig.CredentialStoreName())
+			cmd.Printf("Migrated %d key(s) to %s and removed plaintext credential files.\n", n, hawkconfig.CredentialStoreName())
 		}
 		return nil
 	},

cmd/manpage_test.go

@@ -7,12 +7,12 @@ import (
 )
 
 func TestProviderCountCopyMatchesRegistry(t *testing.T) {
-	const documentedProviderCount = 27
-	if got := registeredProviderCount(); got != documentedProviderCount {
-		t.Fatalf("registered providers = %d, update documented count %d and this assertion", got, documentedProviderCount)
+	count := registeredProviderCount()
+	if count < 20 {
+		t.Fatalf("registered providers = %d, expected a first-class provider registry", count)
 	}
 
-	want := fmt.Sprintf("%d first-class LLM providers", documentedProviderCount)
+	want := fmt.Sprintf("%d first-class LLM providers", count)
 	if !strings.Contains(rootCmd.Long, want) {
 		t.Fatalf("CLI help does not contain registry-backed provider count %q", want)
 	}

cmd/model_table_test.go

@@ -67,6 +67,9 @@ func TestFormatModelCapabilities(t *testing.T) {
 }
 
 func TestFormatModelThinkingCell(t *testing.T) {
+	// Isolate from the developer's real hawk settings (per-model thinking
+	// preferences would otherwise change the asserted defaults).
+	t.Setenv("HOME", t.TempDir())
 	row := modelTableRowFromOption(configModelOption{
 		ID: "demo/no-think", DisplayName: "no-think", Owner: "demo",
 		Capabilities: []string{"tools"},

external/eyrie

@@ -31,7 +31,7 @@ func TestAllSetupGateways_RegistryOnly(t *testing.T) {
 		}
 	}
 	// Required gateways that exist in the published eyrie v0.1.3.
-	want := map[string]bool{"azure": true, "bedrock": true, "gemini": true, "grok": true, "openrouter": true, "kimi": true, "vertex": true, "xiaomi_mimo_payg": true, "xiaomi_mimo_token_plan": true, "deepseek": true, "minimax_token_plan": true, "minimax_payg": true, "zai_payg": true, "zai_coding": true}
+	want := map[string]bool{"azure": true, "bedrock": true, "gemini": true, "grok": true, "openrouter": true, "kimi": true, "vertex": true, "xiaomi_mimo_payg": true, "xiaomi_mimo_token_plan": true, "deepseek": true, "minimax_token_plan": true, "minimax_payg": true, "zai_payg": true, "zai_coding": true, "agnes": true}
 	for id := range want {
 		found := false
 		for _, gw := range gws {

internal/config/catalog_gateways_test.go

@@ -134,15 +134,15 @@ func EvaluateDeveloperPath(ctx context.Context) DeveloperPathReport {
 		})
 	}
 
-	if legacy, paths := legacyCredentialFilesPresent(); legacy {
+	if present, paths := plaintextCredentialFilesPresent(); present {
 		checks = append(checks, PathCheck{
-			Section: "Security", Name: "legacy env", Status: PathWarn,
+			Section: "Security", Name: "plaintext env", Status: PathWarn,
 			Detail:  "Plaintext credential files: " + strings.Join(paths, ", "),
 			FixHint: "Run hawk credentials migrate",
 		})
 	} else {
 		checks = append(checks, PathCheck{
-			Section: "Security", Name: "legacy env", Status: PathPass,
+			Section: "Security", Name: "plaintext env", Status: PathPass,
 			Detail:   "No ~/.hawk/env or ~/.hawk/.env files",
 			Blocking: true,
 		})
@@ -316,7 +316,7 @@ func providerJSONHasSecretsOnDisk() (bool, string) {
 	return status.HasSecrets, status.Detail
 }
 
-func legacyCredentialFilesPresent() (bool, []string) {
+func plaintextCredentialFilesPresent() (bool, []string) {
 	hawkDir := filepath.Join(home.MustDir(), ".hawk")
 	var paths []string
 	for _, name := range []string{"env", ".env"} {

internal/config/developer_path.go

@@ -58,11 +58,11 @@ func TestProviderJSONHasSecretsOnDisk_None(t *testing.T) {
 	}
 }
 
-func TestLegacyCredentialFilesPresent_None(t *testing.T) {
+func TestPlaintextCredentialFilesPresent_None(t *testing.T) {
 	isolateMilestoneTest(t)
-	found, paths := legacyCredentialFilesPresent()
+	found, paths := plaintextCredentialFilesPresent()
 	if found || len(paths) > 0 {
-		t.Fatalf("expected no legacy files, got %v", paths)
+		t.Fatalf("expected no plaintext files, got %v", paths)
 	}
 }
 

internal/config/developer_path_test.go

@@ -56,8 +56,8 @@ func CredentialStorageStatus(ctx context.Context) gateway.CredentialStorageRepor
 	return gateway.CredentialStorage(ctx)
 }
 
-func MigrateLegacyCredentials(ctx context.Context) (int, error) {
-	return gateway.MigrateLegacyCredentials(ctx)
+func MigrateEnvFileCredentials(ctx context.Context) (int, error) {
+	return gateway.MigrateEnvFileCredentials(ctx)
 }
 
 // EnginePreflightReport runs preflight against the default gateway.

internal/config/eyrie_engine.go

@@ -97,42 +97,42 @@ func SetActiveSelection(ctx context.Context, provider, modelID string) error {
 	return engine.SetSelection(ctx, provider, modelID)
 }
 
-// migrateLegacyModelProvider moves model/provider from ~/.hawk/settings.json into eyrie once.
-func migrateLegacyModelProvider(s *Settings) {
+// migrateStoredModelProvider moves model/provider from ~/.hawk/settings.json into eyrie once.
+func migrateStoredModelProvider(s *Settings) {
 	if s == nil {
 		return
 	}
 	ctx := context.Background()
-	legacyModel := strings.TrimSpace(s.Model)
-	legacyProvider := strings.TrimSpace(s.Provider)
+	oldModel := strings.TrimSpace(s.Model)
+	oldProvider := strings.TrimSpace(s.Provider)
 	activeModel := strings.TrimSpace(ActiveModel(ctx))
 	activeProvider := strings.TrimSpace(ActiveProvider(ctx))
 	changed := false
 
-	// Existing Eyrie state is authoritative. Otherwise migrate a legacy pair
+	// Existing Eyrie state is authoritative. Otherwise migrate a stored pair
 	// in one validated write so a rejected model cannot strand only the
 	// provider in the destination or silently erase the user's source value.
 	if activeModel != "" {
-		if legacyModel != "" {
+		if oldModel != "" {
 			s.Model = ""
 			changed = true
 		}
-		if legacyProvider != "" {
+		if oldProvider != "" {
 			s.Provider = ""
 			changed = true
 		}
-	} else if legacyModel != "" {
+	} else if oldModel != "" {
 		provider := activeProvider
 		if provider == "" {
-			provider = legacyProvider
+			provider = oldProvider
 		}
-		if err := SetActiveSelection(ctx, provider, legacyModel); err == nil {
+		if err := SetActiveSelection(ctx, provider, oldModel); err == nil {
 			s.Model = ""
 			s.Provider = ""
 			changed = true
 		}
-	} else if legacyProvider != "" {
-		if activeProvider != "" || SetActiveProvider(ctx, legacyProvider) == nil {
+	} else if oldProvider != "" {
+		if activeProvider != "" || SetActiveProvider(ctx, oldProvider) == nil {
 			s.Provider = ""
 			changed = true
 		}

internal/config/eyrie_selection.go

@@ -26,7 +26,7 @@ func fetchModelsViaRuntime(ctx context.Context, provider string) ([]EngineModel,
 // Settings holds hawk configuration.
 // Hawk: no API keys stored here. Secrets come from the OS secret store via eyrie.
 type Settings struct {
-	// Model and Provider are legacy fields read only for one-time migration into eyrie provider.json.
+	// Model and Provider are retained only for one-time migration into eyrie provider.json.
 	// Hawk does not persist model/provider here; use SetActiveModel / SetActiveProvider.
 	Model           string   `json:"model,omitempty"`
 	Provider        string   `json:"provider,omitempty"`
@@ -210,7 +210,7 @@ func LoadSettings() Settings {
 	if project := findProjectSettings(); project != nil {
 		s = MergeSettings(s, *project)
 	}
-	migrateLegacyModelProvider(&s)
+	migrateStoredModelProvider(&s)
 	return s
 }