From eaf4d9cbd3e4e71feb32de5ed5fdc36d3b97a95b Mon Sep 17 00:00:00 2001 From: Tim Holy Date: Fri, 17 Jul 2026 07:46:23 -0500 Subject: [PATCH] Drop a false claim from the AbsLog{2} worker comment The stats NamedTuple is returned but never read: every call site discards it, and bench/sizesweep.jl only passes the linsolve keyword. Describe what stats records without asserting a consumer. Assisted-by: Claude Opus 4.8 --- src/minimal_covers.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/minimal_covers.jl b/src/minimal_covers.jl index 30f2692..116bf8a 100644 --- a/src/minimal_covers.jl +++ b/src/minimal_covers.jl @@ -374,8 +374,8 @@ end # Worker for `symcover_min(::AbsLog{2})`. Returns `(a, stats)` where `stats` is a # NamedTuple `(; nsolves, lsqriters, linsolve)` recording the number of inner linear -# solves, the total LSQR iterations (0 on the dense path), and which path ran — used -# by the benchmarks. `linsolve` is `:auto`/`:dense` (dense factorization) or `:lsqr` +# solves, the total LSQR iterations (0 on the dense path), and which path ran. +# `linsolve` is `:auto`/`:dense` (dense factorization) or `:lsqr` # (matrix-free, for sparse supports). `start`, when given, is a positive cover of `A` # indexed like `axes(A, 1)` and supplies the first iterate in place of the cold # unweighted solve; the objective is convex, so it changes the path but not the result.