Get-IcingaPartitionSpace returns USB devices

[bewshy]

Since the change to 'Get-IcingaWindowsInformation Win32_Volume -Filter ([string]::Format('DriveType = "{0}"', $DriveType));' USB devices are displayed which can include USB mass storage and licensing dongles. Request to allow filtering based on identifying as 'USB'.

Win32_DiskDrive.InterfaceType exposes this property.
https://learn.microsoft.com/en-us/windows/win32/cimwin32prov/win32-diskdrive#properties

[LordHepipud]

Hello

Thank you for the issue. Does the exclude filter not apply in this case? You can already exclude certain mountpoints and drives.
I would not want to add a switch to fully exclude certain devices like USB devices, because I already can imagine that another issue will appear that licensing dongles are present and external hard drives and both should be considered,

[bewshy]

The current exclude filter does not apply in this case. Yes, some environments might need to monitor USB storage, while others do not, and the noise it produces.

[LordHepipud]

Can you please share the plugin output of an affected system? I don't see a reason on why the exclude filter should not apply here.

[tectumopticum]

I have two USB-dongles mounted AFAIK via dongle-server:

Get-WmiObject Win32_Volume | Format-Table Name, Label, FreeSpace, Capacity, drivetype

Name                                              Label             FreeSpace     Capacity drivetype
----                                              -----             ---------     -------- ---------
\\?\Volume{a2475bf4-0000-0000-0000-100000000000}\ System Reserved   487526400    523235328         3
E:\                                               DONGLE02P        3996078080   3996106752         2
D:\                                               DONGLE01P        2096660480   2096857088         2
C:\                                               SYSTEM          76071690240 105781391360         3
X:\                                                                                                5

Invoke-IcingaCheckPartitionSpace -Verbosity 3 already "hides" these two volumes:

Invoke-IcingaCheckPartitionSpace -Verbosity 3
[INFO] Free Partition Space: 2 Ok (All must be [OK])
\_ [INFO] Partition \\?\Volume{a2475bf4-0000-0000-0000-100000000000}\: 464.94MiB
\_ [INFO] Partition C: 70.86GiB
| volumea2475bf4000000000000100000000000::ifw_partitionspace::free=487526400B;;;0;523235300 c::ifw_partitionspace::free=76087200000B;;;0;105781400000
0

When I explicitly add a service for one of these two volumes, no values regarding size or freespace/capacity are shown:

Invoke-IcingaCheckPartitionSpace -Verbosity 3 -Include D:
[INFO] Free Partition Space: No checks added to this package (All must be [OK])
3

Is this what you want or expect?