Commit d8d8e87
committed
Correct specificity figure and rewrite README styling conventions for accuracy
Re-review of the final-review fixes found two text-only errors:
- .nav-links a's specificity was given as (0,4,1); the compiled selector
(.nav-links[data-astro-cid-*] a[data-astro-cid-*]) is actually (0,3,1).
The conclusion is unchanged (it still outranks .nav-github's (0,2,0)),
only the arithmetic in the comment and deferred-findings.md was wrong.
- The README's styling-conventions bullets described a consistency the
code doesn't have: utilities aren't reserved for "simple" outer-element
rules (7 of 9 components use scoped CSS even for 1-3 declaration rules),
and "never set the same property both ways" is contradicted by Hero's
deliberate utility-base-plus-scoped-media-override pattern. Rewrote the
section to state plainly that the split is by component, not by rule
complexity, that the codebase isn't uniform, and to recommend the
majority (scoped-CSS) pattern for new sections.
11/11 parity tests pass, astro build clean, astro check clean.1 parent 5d2190a commit d8d8e87
2 files changed
Lines changed: 15 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
21 | 26 | | |
22 | | - | |
23 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
0 commit comments