|
| 1 | +/*- |
| 2 | + * #%L |
| 3 | + * JSQLParser library |
| 4 | + * %% |
| 5 | + * Copyright (C) 2004 - 2026 JSQLParser |
| 6 | + * %% |
| 7 | + * Dual licensed under GNU LGPL 2.1 or Apache License 2.0 |
| 8 | + * #L% |
| 9 | + */ |
| 10 | +package net.sf.jsqlparser.statement.create.table; |
| 11 | + |
| 12 | +import static org.junit.jupiter.api.Assertions.assertEquals; |
| 13 | +import static org.junit.jupiter.api.Assertions.assertFalse; |
| 14 | +import static org.junit.jupiter.api.Assertions.assertNull; |
| 15 | +import static org.junit.jupiter.api.Assertions.assertThrows; |
| 16 | +import static org.junit.jupiter.api.Assertions.assertTrue; |
| 17 | + |
| 18 | +import java.math.BigInteger; |
| 19 | +import java.util.List; |
| 20 | +import net.sf.jsqlparser.JSQLParserException; |
| 21 | +import net.sf.jsqlparser.expression.CastExpression; |
| 22 | +import net.sf.jsqlparser.parser.AbstractJSqlParser.Dialect; |
| 23 | +import net.sf.jsqlparser.parser.CCJSqlParserUtil; |
| 24 | +import net.sf.jsqlparser.statement.select.PlainSelect; |
| 25 | +import net.sf.jsqlparser.util.deparser.StatementDeParser; |
| 26 | +import org.junit.jupiter.api.Test; |
| 27 | +import org.junit.jupiter.params.ParameterizedTest; |
| 28 | +import org.junit.jupiter.params.provider.CsvSource; |
| 29 | +import org.junit.jupiter.params.provider.ValueSource; |
| 30 | + |
| 31 | +class TypeMetadataTest { |
| 32 | + |
| 33 | + @ParameterizedTest |
| 34 | + @CsvSource(delimiter = '|', value = { |
| 35 | + "MYSQL | DECIMAL(65, 30) | DECIMAL | 65 | 30", |
| 36 | + "MYSQL | NUMERIC(1, 0) | NUMERIC | 1 | 0", |
| 37 | + "MYSQL | VARCHAR(255) | VARCHAR | 255 |", |
| 38 | + "MYSQL | NATIONAL VARCHAR(20) | NATIONAL VARCHAR | 20 |", |
| 39 | + "MYSQL | mediumint(9) UNSIGNED | mediumint | 9 |", |
| 40 | + "MYSQL | ENUM('a(b)', 'c') | ENUM | |", |
| 41 | + "POSTGRESQL | NUMERIC(1000, 1000) | NUMERIC | 1000 | 1000", |
| 42 | + "POSTGRESQL | NUMERIC(3, 5) | NUMERIC | 3 | 5", |
| 43 | + "POSTGRESQL | DECIMAL(10) | DECIMAL | 10 |", |
| 44 | + "POSTGRESQL | CHARACTER VARYING(255) | CHARACTER VARYING | 255 |", |
| 45 | + "POSTGRESQL | TIMESTAMP(6) WITH TIME ZONE | TIMESTAMP WITH TIME ZONE | 6 |", |
| 46 | + "POSTGRESQL | TIME(0) WITHOUT TIME ZONE | TIME WITHOUT TIME ZONE | 0 |", |
| 47 | + "POSTGRESQL | NUMERIC(10, 2)[] | NUMERIC | 10 | 2", |
| 48 | + "POSTGRESQL | INTERVAL(6) | INTERVAL | 6 |"}) |
| 49 | + void exposesMetadataAcrossFragmentsDdlAndPostgreSqlCasts(Dialect dialect, String typeName, |
| 50 | + String base, Integer precision, Integer scale) throws JSQLParserException { |
| 51 | + ColDataType fragment = parseType(typeName, dialect); |
| 52 | + assertMetadata(fragment, base, precision, scale); |
| 53 | + CreateTable table = (CreateTable) CCJSqlParserUtil.parse( |
| 54 | + "CREATE TABLE type_case (v " + typeName + ")", p -> p.withDialect(dialect)); |
| 55 | + assertMetadata(table.getColumnDefinitions().get(0).getColDataType(), base, precision, |
| 56 | + scale); |
| 57 | + assertMetadata(parseType(fragment.toString(), dialect), base, precision, scale); |
| 58 | + if (dialect == Dialect.POSTGRESQL) { |
| 59 | + PlainSelect select = (PlainSelect) CCJSqlParserUtil.parse( |
| 60 | + "SELECT CAST(NULL AS " + typeName + ")", p -> p.withDialect(dialect)); |
| 61 | + CastExpression cast = select.getSelectItem(0).getExpression(CastExpression.class); |
| 62 | + assertMetadata(cast.getColDataType(), base, precision, scale); |
| 63 | + } |
| 64 | + } |
| 65 | + |
| 66 | + // MySQL BLOB/TEXT family boundaries and the signed-int boundary, verified on MySQL 8.4. |
| 67 | + @ParameterizedTest |
| 68 | + @ValueSource(strings = {"0", "1", "255", "256", "65535", "65536", "16777215", |
| 69 | + "16777216", "2147483647", "2147483648", "4294967295"}) |
| 70 | + void retainsLargeMySqlLengthsThroughBothRenderers(String length) throws JSQLParserException { |
| 71 | + BigInteger expected = new BigInteger(length); |
| 72 | + for (String name : List.of("BLOB", "TEXT")) { |
| 73 | + ColDataType fragment = parseType(name + "(" + length + ")", Dialect.MYSQL); |
| 74 | + assertEquals(name, fragment.getBaseTypeName()); |
| 75 | + assertEquals(expected, fragment.getNumericPrecision()); |
| 76 | + assertFalse(fragment.isMaxPrecision()); |
| 77 | + assertFalse(fragment.toString().contains("MAX")); |
| 78 | + assertEquals(expected.bitLength() < Integer.SIZE ? Integer.valueOf(length) : null, |
| 79 | + fragment.getPrecision()); |
| 80 | + CreateTable table = (CreateTable) CCJSqlParserUtil.parse( |
| 81 | + "CREATE TABLE type_case (v " + name + "(" + length + "))", |
| 82 | + p -> p.withDialect(Dialect.MYSQL)); |
| 83 | + StringBuilder visitor = new StringBuilder(); |
| 84 | + table.accept(new StatementDeParser(visitor)); |
| 85 | + for (String rendered : List.of(table.toString(), visitor.toString())) { |
| 86 | + CreateTable reparsed = (CreateTable) CCJSqlParserUtil.parse(rendered, |
| 87 | + p -> p.withDialect(Dialect.MYSQL)); |
| 88 | + ColDataType type = reparsed.getColumnDefinitions().get(0).getColDataType(); |
| 89 | + assertEquals(expected, type.getNumericPrecision()); |
| 90 | + assertFalse(type.isMaxPrecision()); |
| 91 | + } |
| 92 | + } |
| 93 | + } |
| 94 | + |
| 95 | + @Test |
| 96 | + void distinguishesMaxKeywordFromItsLegacySentinelValue() throws JSQLParserException { |
| 97 | + ColDataType max = parseType("VARCHAR(MAX)", Dialect.SQLSERVER); |
| 98 | + assertTrue(max.isMaxPrecision()); |
| 99 | + assertNull(max.getNumericPrecision()); |
| 100 | + assertEquals(Integer.MAX_VALUE, max.getPrecision()); |
| 101 | + assertEquals("VARCHAR (MAX)", max.getDataType()); |
| 102 | + ColDataType literal = parseType("BLOB(2147483647)", Dialect.MYSQL); |
| 103 | + assertFalse(literal.isMaxPrecision()); |
| 104 | + assertEquals(BigInteger.valueOf(Integer.MAX_VALUE), literal.getNumericPrecision()); |
| 105 | + assertEquals("BLOB (2147483647)", literal.getDataType()); |
| 106 | + assertEquals("VARCHAR (MAX)", new ColDataType("VARCHAR", Integer.MAX_VALUE, -1).toString()); |
| 107 | + assertNull(new ColDataType("VARCHAR", -1, -1).getNumericPrecision()); |
| 108 | + } |
| 109 | + |
| 110 | + @Test |
| 111 | + void metadataSettersDoNotLeaveStaleLargeOrMaxValues() throws JSQLParserException { |
| 112 | + ColDataType type = parseType("BLOB(4294967295)", Dialect.MYSQL); |
| 113 | + type.setPrecision(5); |
| 114 | + assertEquals(BigInteger.valueOf(5), type.getNumericPrecision()); |
| 115 | + type.setPrecision(null); |
| 116 | + assertNull(type.getNumericPrecision()); |
| 117 | + type = parseType("VARCHAR(MAX)", Dialect.SQLSERVER); |
| 118 | + type.setNumericPrecision(BigInteger.valueOf(2147483648L)); |
| 119 | + assertFalse(type.isMaxPrecision()); |
| 120 | + assertNull(type.getPrecision()); |
| 121 | + assertEquals(BigInteger.valueOf(2147483648L), type.getNumericPrecision()); |
| 122 | + } |
| 123 | + |
| 124 | + @ParameterizedTest |
| 125 | + @ValueSource(strings = {"\"odd(type)\"", "public.\"odd(type)\"", "\"a\"\"(b)\""}) |
| 126 | + void retainsQuotedParenthesesAndQualification(String name) throws JSQLParserException { |
| 127 | + assertEquals(name, parseType(name, Dialect.POSTGRESQL).getBaseTypeName()); |
| 128 | + ColDataType manual = new ColDataType(name, 10, 2); |
| 129 | + assertEquals(name, manual.getBaseTypeName()); |
| 130 | + assertEquals(name + " (10, 2)", manual.getDataType()); |
| 131 | + } |
| 132 | + |
| 133 | + @Test |
| 134 | + void baseNameFollowsLegacyTypeEditsWithoutStaleCache() { |
| 135 | + ColDataType type = new ColDataType("DECIMAL", 10, 2); |
| 136 | + type.setDataType("VARCHAR (20)"); |
| 137 | + assertEquals("VARCHAR", type.getBaseTypeName()); |
| 138 | + assertEquals("VARCHAR (20)", type.getDataType()); |
| 139 | + type.setDataType(List.of("app", "\"kind(1)\"")); |
| 140 | + assertEquals("app.\"kind(1)\"", type.getBaseTypeName()); |
| 141 | + type.setDataType((String) null); |
| 142 | + assertNull(type.getBaseTypeName()); |
| 143 | + } |
| 144 | + |
| 145 | + @ParameterizedTest |
| 146 | + @ValueSource(strings = {"BLOB(-1)", "BLOB(1.5)", "BLOB(4294967295", "DECIMAL(10,)"}) |
| 147 | + void rejectsMalformedNumericParameters(String type) { |
| 148 | + assertThrows(JSQLParserException.class, () -> parseType(type, Dialect.MYSQL)); |
| 149 | + } |
| 150 | + |
| 151 | + @Test |
| 152 | + void leavesDatabaseSpecificRangeValidationToTheDatabase() throws JSQLParserException { |
| 153 | + // Syntactically numeric, but MySQL rejects this BLOB length as out of range. |
| 154 | + String length = "18446744073709551616"; |
| 155 | + assertEquals(new BigInteger(length), |
| 156 | + parseType("BLOB(" + length + ")", Dialect.MYSQL).getNumericPrecision()); |
| 157 | + } |
| 158 | + |
| 159 | + private static ColDataType parseType(String sql, Dialect dialect) throws JSQLParserException { |
| 160 | + return CCJSqlParserUtil.parseColDataType(sql, p -> p.withDialect(dialect)); |
| 161 | + } |
| 162 | + |
| 163 | + private static void assertMetadata(ColDataType type, String base, Integer precision, |
| 164 | + Integer scale) { |
| 165 | + assertEquals(base, type.getBaseTypeName()); |
| 166 | + assertEquals(precision, type.getPrecision()); |
| 167 | + assertEquals(precision == null ? null : BigInteger.valueOf(precision), |
| 168 | + type.getNumericPrecision()); |
| 169 | + assertEquals(scale, type.getScale()); |
| 170 | + } |
| 171 | +} |
0 commit comments