fix: more minor fixes

Author: Neil-Tomar

src/main/java/net/discordjug/javabot/systems/user_commands/format_code/FormatCodeCommand.java

@@ -12,8 +12,6 @@
 
 import org.jetbrains.annotations.NotNull;
 
-import java.util.Collections;
-
 /**
  * <h3>This class represents the /format-code command.</h3>
  */
@@ -61,7 +59,6 @@ public void execute(@NotNull SlashCommandInteractionEvent event) {
 			event.getChannel().getHistory()
 					.retrievePast(10)
 					.queue(messages -> {
-						Collections.reverse(messages);
 						Message target = messages.stream()
 								.filter(m -> !m.getAuthor().isBot()).findFirst()
 								.orElse(null);

src/main/java/net/discordjug/javabot/systems/user_commands/format_code/FormatCodeDispatcher.java

@@ -6,12 +6,10 @@
 import net.dv8tion.jda.api.entities.Message;
 import net.dv8tion.jda.api.entities.channel.middleman.MessageChannel;
 import net.dv8tion.jda.api.interactions.commands.CommandInteraction;
-import net.dv8tion.jda.api.utils.FileUpload;
 import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.NotNull;
 
 import javax.annotation.Nonnull;
-import java.nio.charset.StandardCharsets;
 import java.util.List;
 
 /**
@@ -22,7 +20,7 @@
 class FormatCodeDispatcher {
 
 	/**
-	 * The maximum number of code-block messages to post inline; longer code is sent only as a file.
+	 * The maximum number of code-block messages to post inline; longer code results as an ERROR.
 	 */
 	private static final int MAX_MESSAGES = 5;
 
@@ -43,18 +41,15 @@ public static void sendCode(Code code, @Nonnull CommandInteraction event, Messag
 
 		List<String> messages = code.toDiscordMessages();
 
-		// The reply both acknowledges the interaction and hands users the full,
-		// un-split code as a downloadable file (so chunking never loses anything).
-		FileUpload file = FileUpload.fromData(
-				code.getContent().getBytes(StandardCharsets.UTF_8),
-				"code." + code.getLanguage().getDiscordName()
-		);
-
 		MessageChannel channel = target.getChannel();
 
-		event.replyFiles(file)
-				.setAllowedMentions(List.of())
-				.setComponents(buildActionRow(target, event.getUser().getIdLong()))
+		if (messages.size() > MAX_MESSAGES) {
+			Responses.errorWithTitle(event.getHook(), "Output Too Large", "The formatted result is too large to send. Please provide a smaller code snippet or use a paste service instead."
+			).queue();
+			return;
+		}
+
+		Responses.success(event, "Success", "The formatted message is being sent to this channel.")
 				.queue(success -> sendChunksInOrder(channel, messages, 0, target,event));
 	}
 
@@ -63,11 +58,6 @@ private static void sendChunksInOrder(MessageChannel channel, List<String> messa
 		if (index >= messages.size()) {
 			return;
 		}
-		if (messages.size() > MAX_MESSAGES) {
-			Responses.errorWithTitle(event.getHook(), "Output Too Large", "The formatted result is too large to send. Please provide a smaller code snippet or use a paste service instead."
-			).queue();
-			return;
-		}
 		var action = channel.sendMessage(messages.get(index))
 				.setAllowedMentions(List.of());
 
@@ -101,7 +91,7 @@ private static void sendChunksInOrder(MessageChannel channel, List<String> messa
 	 * @param requesterId the id of the user permitted to delete the message
 	 * @return an action row containing the delete and "View Original" buttons
 	 */
-	@Contract("_ -> new")
+	@Contract("_,_ -> new")
 	static @NotNull ActionRow buildActionRow(@NotNull Message target, long requesterId) {
 		return ActionRow.of(InteractionUtils.createDeleteButton(requesterId),
 				Button.link(target.getJumpUrl(), "View Original"));

src/main/java/net/discordjug/javabot/systems/user_commands/format_code/Language.java

@@ -83,9 +83,13 @@ public enum Language {
 	 */
 	JSON("JSON", "json"),
 	/**
-	 * Fallback used when the language is unrecognised; renders as plain text.
+	 * Simple plain text.
 	 */
-	UNKNOWN("Unknown", "txt");
+	TXT("TXT", "txt"),
+	/**
+	 * Fallback used when the language is unrecognised.
+	 */
+	UNKNOWN("Unknown", "");
 
 	private final String displayName;
 	private final String discordName;