Repository navigation
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 75.31% 73.34% -1.97%
==========================================
Files 2 2
Lines 401 424 +23
==========================================
+ Hits 302 311 +9
- Misses 99 113 +14
☔ View full report in Codecov by Sentry. |
Member
|
[comment generated via AI] Thanks for the proposal. StructTypes is in maintenance mode (JSON.jl 1.x builds on StructUtils instead) and only gets fixes now, so closing. JSON.jl 1.x handles abstract types with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to remove a lot of the boilerplate necessary for dealing with abstract types:
Under the hood:
__type__key is added to the serialized JSON (configurable via@auto MyType mysubtypekey.evalto get the deserialized type from the__type__. I examine theMeta.parse-edExprto order to determine whether it's safe toeval. I typically don't mess witheval, so I may have missed something that makes this unsafe.