Repository navigation
Add Runic formatter - #76
Merged
Merged
Conversation
Collaborator
|
Fine by me. But why didn't the CI job fail? |
Member
Author
|
it's not a check; when you make edits to files, it will add comments w/ format changes and then you can apply them all. I'll do a follow-up PR splitting validation and generation w/ formats applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/fredrikekre/Runic.jl has become my preferred Julia formatter. Simple, and the README has detailed instructions on how to set it up in any/all the ways (IDE, git hook, CI, etc.). This enables posting review comments on PRs for formatting changes. I also have a local pre-commit hook that will format.