From 6b83160f9aa7e361bd689b538ad6ed67592afc31 Mon Sep 17 00:00:00 2001 From: Matt Dawkins Date: Wed, 2 Sep 2026 12:28:41 -0400 Subject: [PATCH] Stop passing --no-embedded-pipe to viame train Runnable pipelines are the training tool's default now, so the flag is a deprecated no-op. Requires a VIAME build with the inverted default; on older builds the flag was needed to get runnable pipes. --- client/platform/desktop/backend/native/viame.ts | 1 - server/dive_tasks/run_training.py | 1 - server/tests/test_remote_ffprobe.py | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/client/platform/desktop/backend/native/viame.ts b/client/platform/desktop/backend/native/viame.ts index 5fe893360..eec706cc6 100644 --- a/client/platform/desktop/backend/native/viame.ts +++ b/client/platform/desktop/backend/native/viame.ts @@ -920,7 +920,6 @@ async function train( `--config "${configFilePath}"`, '--no-query', '--no-adv-prints', - '--no-embedded-pipe', ]; if (resumeDir) { diff --git a/server/dive_tasks/run_training.py b/server/dive_tasks/run_training.py index 013a3b47f..b6347cb16 100644 --- a/server/dive_tasks/run_training.py +++ b/server/dive_tasks/run_training.py @@ -152,7 +152,6 @@ def train_pipeline(self: Task, params: TrainingJob): "--config", shlex.quote(str(config_file)), "--no-query", - "--no-embedded-pipe", ] if annotated_frames_only: diff --git a/server/tests/test_remote_ffprobe.py b/server/tests/test_remote_ffprobe.py index 14b68ffb5..66c0d494c 100644 --- a/server/tests/test_remote_ffprobe.py +++ b/server/tests/test_remote_ffprobe.py @@ -84,7 +84,7 @@ def test_sanitize_subprocess_args_keeps_header_file_path(): def test_sanitize_subprocess_args_keeps_shell_command_string(): cmd = ( '. /opt/noaa/viame/setup_viame.sh && KWIVER_DEFAULT_LOG_LEVEL=warn ' - '/opt/noaa/viame/bin/viame train --no-query --no-embedded-pipe' + '/opt/noaa/viame/bin/viame train --no-query' ) assert utils.sanitize_subprocess_args_for_log(cmd) == cmd