From acebe3ae0e70ec6f427ddaa994eaa77910c07b15 Mon Sep 17 00:00:00 2001 From: Simon Shanks Date: Tue, 15 Sep 2026 14:04:54 +0100 Subject: [PATCH 1/3] Prefer 'static readonly' fields --- kx.Test/Types/DictTests.cs | 8 +++++--- kx.Test/Types/FlipTests.cs | 10 ++++++---- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/kx.Test/Types/DictTests.cs b/kx.Test/Types/DictTests.cs index 5aecfeb..42a85fc 100644 --- a/kx.Test/Types/DictTests.cs +++ b/kx.Test/Types/DictTests.cs @@ -6,10 +6,12 @@ namespace kx.Test.Types [TestFixture] public class DictTests { + private static readonly string[] DictKeys = {"Key_1"}; + private static readonly object[] DictValues = {new object[] { "Value_1" }}; [Test] public void DictInitialises() { - var dict = new c.Dict(new string[] { "Key_1" }, new object[] { "Value_1" }); + var dict = new c.Dict(DictKeys, DictValues); Assert.IsNotNull(dict); } @@ -18,14 +20,14 @@ public void DictInitialises() public void DictThrowsIfKeysIsNull() { Assert.Throws(() => - new c.Dict(null, new object[] { "Value_1" })); + new c.Dict(null, DictValues)); } [Test] public void DictThrowsIfValuesIsNull() { Assert.Throws(() => - new c.Dict(new string[] { "Key_1" }, null)); + new c.Dict(DictKeys, null)); } } } diff --git a/kx.Test/Types/FlipTests.cs b/kx.Test/Types/FlipTests.cs index dd20e8d..8beac72 100644 --- a/kx.Test/Types/FlipTests.cs +++ b/kx.Test/Types/FlipTests.cs @@ -6,10 +6,12 @@ namespace kx.Test.Types [TestFixture] public class FlipTests { + private static readonly string[] FlipKeys = {"Key_1"}; + private static readonly object[] FlipValues = {new object[] { "Value_1" }}; [Test] public void FlipInitialises() { - var flip = new c.Flip(new c.Dict(new string[] { "Key_1" }, new object[] { "Value_1" })); + var flip = new c.Flip(new c.Dict(FlipKeys, FlipValues)); Assert.IsNotNull(flip); } @@ -23,7 +25,7 @@ public void FlipThrowsIfDictIsNull() [Test] public void FlipAtReturnsValueForColumnName() { - var flip = new c.Flip(new c.Dict(new string[] { "Key_1" }, new object[] { "Value_1" })); + var flip = new c.Flip(new c.Dict(FlipKeys, FlipValues)); object result = flip.at("Key_1"); @@ -34,7 +36,7 @@ public void FlipAtReturnsValueForColumnName() [Test] public void FlipAtThrowsIfColumnNameIfNotFound() { - var flip = new c.Flip(new c.Dict(new string[] { "Key_1" }, new object[] { "Value_1" })); + var flip = new c.Flip(new c.Dict(FlipKeys, FlipValues)); Assert.Throws(() => flip.at("Aardvark")); } @@ -42,7 +44,7 @@ public void FlipAtThrowsIfColumnNameIfNotFound() [Test] public void FlipAtThrowsIfColumnNameIfNull() { - var flip = new c.Flip(new c.Dict(new string[] { "Key_1" }, new object[] { "Value_1" })); + var flip = new c.Flip(new c.Dict(FlipKeys, FlipValues)); Assert.Throws(() => flip.at(null)); } From b16a99e26c59c9dd8d3a2ec7956c7d6cf5ef3993 Mon Sep 17 00:00:00 2001 From: Simon Shanks Date: Tue, 15 Sep 2026 14:09:35 +0100 Subject: [PATCH 2/3] member can be marked as static --- kx.Test/Connection/ConnectionAsyncWriteTests.cs | 4 ++-- kx.Test/Connection/ConnectionSerialisationTests.cs | 2 +- kx.Test/Connection/ConnectionSyncWriteTests.cs | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kx.Test/Connection/ConnectionAsyncWriteTests.cs b/kx.Test/Connection/ConnectionAsyncWriteTests.cs index 81fd4ae..a992508 100644 --- a/kx.Test/Connection/ConnectionAsyncWriteTests.cs +++ b/kx.Test/Connection/ConnectionAsyncWriteTests.cs @@ -263,7 +263,7 @@ public async Task ConnectionWritesExpectedStringExpressionAndParametersToClientS } } - private Mock CreateTestStream(List bytesWritten) + private static Mock CreateTestStream(List bytesWritten) { Mock testStream = new Mock(); @@ -283,4 +283,4 @@ private Mock CreateTestStream(List bytesWritten) return testStream; } } -} \ No newline at end of file +} diff --git a/kx.Test/Connection/ConnectionSerialisationTests.cs b/kx.Test/Connection/ConnectionSerialisationTests.cs index 209f5ec..6bf03be 100644 --- a/kx.Test/Connection/ConnectionSerialisationTests.cs +++ b/kx.Test/Connection/ConnectionSerialisationTests.cs @@ -1013,7 +1013,7 @@ public void ConnectionSerialisesAndDeserialisesTimeSpanArrayInputWithZipEnabled( } - private T[] CreateTestArray(Func elementBuilder, int arraySize) + private static T[] CreateTestArray(Func elementBuilder, int arraySize) { T[] array = new T[arraySize]; diff --git a/kx.Test/Connection/ConnectionSyncWriteTests.cs b/kx.Test/Connection/ConnectionSyncWriteTests.cs index 2332f5f..7031d04 100644 --- a/kx.Test/Connection/ConnectionSyncWriteTests.cs +++ b/kx.Test/Connection/ConnectionSyncWriteTests.cs @@ -181,7 +181,7 @@ public void ConnectionWritesExpectedStringExpressionAndThreeObjectParametersToCl } } - private Mock CreateTestStream(List bytesWritten) + private static Mock CreateTestStream(List bytesWritten) { Mock testStream = new Mock(); @@ -221,4 +221,4 @@ private Mock CreateTestStream(List bytesWritten) return testStream; } } -} \ No newline at end of file +} From 84586031393809aa3f186890595750401f918c46 Mon Sep 17 00:00:00 2001 From: Simon Shanks Date: Tue, 15 Sep 2026 14:44:39 +0100 Subject: [PATCH 3/3] fix test --- kx.Test/Types/DictTests.cs | 2 +- kx.Test/Types/FlipTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kx.Test/Types/DictTests.cs b/kx.Test/Types/DictTests.cs index 42a85fc..8960078 100644 --- a/kx.Test/Types/DictTests.cs +++ b/kx.Test/Types/DictTests.cs @@ -7,7 +7,7 @@ namespace kx.Test.Types public class DictTests { private static readonly string[] DictKeys = {"Key_1"}; - private static readonly object[] DictValues = {new object[] { "Value_1" }}; + private static readonly object[] DictValues = {"Value_1"}; [Test] public void DictInitialises() { diff --git a/kx.Test/Types/FlipTests.cs b/kx.Test/Types/FlipTests.cs index 8beac72..6dda58a 100644 --- a/kx.Test/Types/FlipTests.cs +++ b/kx.Test/Types/FlipTests.cs @@ -7,7 +7,7 @@ namespace kx.Test.Types public class FlipTests { private static readonly string[] FlipKeys = {"Key_1"}; - private static readonly object[] FlipValues = {new object[] { "Value_1" }}; + private static readonly object[] FlipValues = { "Value_1" }; [Test] public void FlipInitialises() {