Skip to content

fix(dag): enforce deep review terminal gates #146

Description

@LeXwDeX

Description\n\nDeep review lifecycle validation accepts a graph ending at a diff review. A structured REJECT is still persisted as NodeCompleted, so a deep workflow can finish successfully without a final gate or correction path.\n\nSeverity: HIGH (release blocker).\n\n## Reproduce\n\n1. Create a deep graph: implementation → verification(PASS) → diff review.\n2. Omit any downstream final audit/gate.\n3. Return a valid REJECT payload from the review node.\n4. The review node completes and the workflow can reach completed.\n\n## Acceptance\n\n- Deep diff-review topology cannot end without a downstream terminal gate/audit.\n- A REJECT cannot produce a successful workflow completion without a correction/reverification/re-review path.\n- ACCEPT remains bound to the current implementation fingerprint.\n- Tests cover missing final gate, REJECT, correction, and stale fingerprints.\n

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions