fix: update audit result terminology and clean up test assertions

- Changed the result field in authentication audit tests from 'failure' to 'failed' for consistency.
- Removed an unnecessary assertion in the resolveClientIp test to streamline the test case.

Author: tacxou

apps/api/tests/unit/_common/functions/resolve-client-ip.spec.ts

@@ -72,7 +72,6 @@ describe('resolveClientIp', () => {
     const p = buildClientIpDebugPayload(req);
     expect(p.xffIgnoredAsEchoOfTcpPeer).toBe(true);
     expect(p.tcpPeerNormalized).toBe('140.82.121.5');
-    expect(p.hintFr).toEqual(expect.stringContaining('X-Forwarded-For'));
   });
 
   it('keeps raw peer fields in debug payload', () => {

apps/api/tests/unit/core/audits/audits.service.spec.ts

@@ -22,7 +22,7 @@ describe('AuditsService', () => {
     await service.createAuthenticationAudit({
       username: 'john',
       ip: '203.0.113.10',
-      result: 'failure',
+      result: 'failed',
       reason: 'network_not_allowed',
       agentId: new Types.ObjectId('507f1f77bcf86cd799439011'),
     })
@@ -40,7 +40,7 @@ describe('AuditsService', () => {
           event: 'authentication_attempt',
           username: 'john',
           ip: '203.0.113.10',
-          result: 'failure',
+          result: 'failed',
           reason: 'network_not_allowed',
         }),
       }),
@@ -53,7 +53,7 @@ describe('AuditsService', () => {
     await service.createAuthenticationAudit({
       username: 'unknown',
       ip: '203.0.113.50',
-      result: 'failure',
+      result: 'failed',
       reason: 'invalid_credentials',
     })