From e228572059d157ea172cbd2490db6d8fc04460a1 Mon Sep 17 00:00:00 2001 From: nextcloud-command Date: Sun, 18 Oct 2026 07:03:51 +0000 Subject: [PATCH 1/3] chore(dev-deps): Bump nextcloud/ocp package Signed-off-by: GitHub --- composer.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/composer.lock b/composer.lock index 334fb57004..10b33b9774 100644 --- a/composer.lock +++ b/composer.lock @@ -264,12 +264,12 @@ "source": { "type": "git", "url": "https://github.com/nextcloud-deps/ocp.git", - "reference": "b31a1787fbc7fd6616508bfefd1459ae3bc9b2b4" + "reference": "1f372f9d20bc38860d1d11a55c1c16293b759e6c" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/nextcloud-deps/ocp/zipball/b31a1787fbc7fd6616508bfefd1459ae3bc9b2b4", - "reference": "b31a1787fbc7fd6616508bfefd1459ae3bc9b2b4", + "url": "https://api.github.com/repos/nextcloud-deps/ocp/zipball/1f372f9d20bc38860d1d11a55c1c16293b759e6c", + "reference": "1f372f9d20bc38860d1d11a55c1c16293b759e6c", "shasum": "" }, "require": { @@ -309,7 +309,7 @@ "issues": "https://github.com/nextcloud-deps/ocp/issues", "source": "https://github.com/nextcloud-deps/ocp/tree/stable35" }, - "time": "2026-10-01T20:27:39+00:00" + "time": "2026-10-09T03:32:50+00:00" }, { "name": "psr/clock", From e5181854a4fcdc1f4a7181abab5ad3a7f0e68e8e Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Mon, 19 Oct 2026 14:30:02 +0000 Subject: [PATCH 2/3] test(controller): provide validation policy service in PageController tests Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- tests/php/Unit/Controller/PageControllerTest.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/php/Unit/Controller/PageControllerTest.php b/tests/php/Unit/Controller/PageControllerTest.php index 2654d45f1a..cb4adc5246 100644 --- a/tests/php/Unit/Controller/PageControllerTest.php +++ b/tests/php/Unit/Controller/PageControllerTest.php @@ -21,6 +21,7 @@ use OCA\Libresign\Service\IdentifyMethodService; use OCA\Libresign\Service\Policy\PolicyAuthorizationService; use OCA\Libresign\Service\Policy\PolicyService; +use OCA\Libresign\Service\Policy\ValidationEffectivePolicyService; use OCA\Libresign\Service\RequestSignatureService; use OCA\Libresign\Service\SessionService; use OCA\Libresign\Service\SignerElementsService; @@ -144,6 +145,7 @@ public function setUp(): void { signFileService: $this->signFileService, requestSignatureService: \OCP\Server::get(RequestSignatureService::class), policyService: $this->policyService, + validationEffectivePolicyService: $this->createMock(ValidationEffectivePolicyService::class), policyAuthorizationService: $this->policyAuthorizationService, signerElementsService: $this->signerElementsService, l10n: $this->createMock(IL10N::class), @@ -298,6 +300,7 @@ public function testValidationFilePublicBootstrapsRequesterPoliciesWithoutUserSc signFileService: $signFileService, requestSignatureService: \OCP\Server::get(RequestSignatureService::class), policyService: $policyService, + validationEffectivePolicyService: $this->createMock(ValidationEffectivePolicyService::class), policyAuthorizationService: $this->policyAuthorizationService, signerElementsService: $this->signerElementsService, l10n: $this->createMock(IL10N::class), From c468dcbecfd832426bd4ef3dcb3d99208750731b Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Mon, 19 Oct 2026 14:51:08 +0000 Subject: [PATCH 3/3] test(controller): instantiate final validation policy service Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- tests/php/Unit/Controller/PageControllerTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/php/Unit/Controller/PageControllerTest.php b/tests/php/Unit/Controller/PageControllerTest.php index cb4adc5246..d228662f4e 100644 --- a/tests/php/Unit/Controller/PageControllerTest.php +++ b/tests/php/Unit/Controller/PageControllerTest.php @@ -145,7 +145,7 @@ public function setUp(): void { signFileService: $this->signFileService, requestSignatureService: \OCP\Server::get(RequestSignatureService::class), policyService: $this->policyService, - validationEffectivePolicyService: $this->createMock(ValidationEffectivePolicyService::class), + validationEffectivePolicyService: new ValidationEffectivePolicyService($this->policyService), policyAuthorizationService: $this->policyAuthorizationService, signerElementsService: $this->signerElementsService, l10n: $this->createMock(IL10N::class), @@ -300,7 +300,7 @@ public function testValidationFilePublicBootstrapsRequesterPoliciesWithoutUserSc signFileService: $signFileService, requestSignatureService: \OCP\Server::get(RequestSignatureService::class), policyService: $policyService, - validationEffectivePolicyService: $this->createMock(ValidationEffectivePolicyService::class), + validationEffectivePolicyService: new ValidationEffectivePolicyService($policyService), policyAuthorizationService: $this->policyAuthorizationService, signerElementsService: $this->signerElementsService, l10n: $this->createMock(IL10N::class),