Skip to content

Lame-duck mode is not yet implemented #8

Description

@Merovius

When the server is shutting down (by a cancelled context) it shouldn't just abort handling requests, but instead reply to them with ESHUTDOWN or NBD_REP_ERR_SHUTDOWN, until the client disconnects. This is unfortunate in that it means cancellation isn't immediate - if the client refuses to disconnect, Serve would block forever. Maybe we need a secondary cancellation signal for that.

Likewise, if the client receives an ESHUTDOWN or NBD_REP_ERR_SHUTDOWN response at any point, it should send an Abort/Disconnect.

Relevant spec values:

  • ESHUTDOWN
  • NBD_REP_ERR_SHUTDOWN

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    betaIssues that should be fixed or closed as wontfix in v0

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions