From d8de588489c9c15121a3bb3d5f0d7289a9551afd Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Fri, 24 Oct 2025 08:37:42 -0600 Subject: [PATCH 1/2] Improve preview builds When we added preview builds to some polyrepos, we copied the workflow from this repo and made some improvements at the same time. This commit applies those same improvements. - Add emoji reaction to preview build request comment when workflow begins. - Simplify preview build docs by removing external contributor-specific instructions. - Remove package scripts from root and workspace packages. The scripts used by the preview build workflow aren't meant to be called explicitly, and in fact may be dangerous to do so. This also makes the workflow more copy-and-pasteable to other projects. - Convert script to generate reply comment to bash. - Simplify output in reply comment, and fix link to docs. --- .github/workflows/publish-preview.yml | 52 +++++++++---- docs/contributing.md | 78 +++++++------------ package.json | 2 - packages/account-tree-controller/package.json | 1 - packages/accounts-controller/package.json | 1 - packages/address-book-controller/package.json | 1 - packages/announcement-controller/package.json | 1 - packages/app-metadata-controller/package.json | 1 - packages/approval-controller/package.json | 1 - packages/assets-controllers/package.json | 1 - packages/base-controller/package.json | 1 - packages/bridge-controller/package.json | 1 - .../bridge-status-controller/package.json | 1 - packages/build-utils/package.json | 1 - .../chain-agnostic-permission/package.json | 1 - packages/composable-controller/package.json | 1 - packages/controller-utils/package.json | 1 - packages/core-backend/package.json | 1 - packages/delegation-controller/package.json | 1 - packages/earn-controller/package.json | 1 - packages/eip-5792-middleware/package.json | 1 - .../package.json | 1 - .../package.json | 1 - packages/ens-controller/package.json | 1 - packages/error-reporting-service/package.json | 1 - packages/eth-block-tracker/package.json | 1 - packages/eth-json-rpc-middleware/package.json | 1 - packages/eth-json-rpc-provider/package.json | 1 - packages/foundryup/package.json | 1 - packages/gas-fee-controller/package.json | 1 - .../gator-permissions-controller/package.json | 1 - packages/json-rpc-engine/package.json | 1 - .../json-rpc-middleware-stream/package.json | 1 - packages/keyring-controller/package.json | 1 - packages/logging-controller/package.json | 1 - packages/message-manager/package.json | 1 - packages/messenger/package.json | 1 - .../multichain-account-service/package.json | 1 - .../multichain-api-middleware/package.json | 1 - .../package.json | 3 +- .../package.json | 1 - packages/name-controller/package.json | 1 - packages/network-controller/package.json | 1 - .../package.json | 1 - .../package.json | 1 - packages/permission-controller/package.json | 1 - .../permission-log-controller/package.json | 1 - packages/phishing-controller/package.json | 1 - packages/polling-controller/package.json | 1 - packages/preferences-controller/package.json | 1 - packages/profile-sync-controller/package.json | 1 - packages/rate-limit-controller/package.json | 1 - .../package.json | 1 - packages/sample-controllers/package.json | 1 - .../package.json | 1 - .../selected-network-controller/package.json | 1 - packages/shield-controller/package.json | 1 - packages/signature-controller/package.json | 1 - packages/subscription-controller/package.json | 1 - .../package.json | 1 - packages/transaction-controller/package.json | 1 - .../user-operation-controller/package.json | 1 - scripts/generate-preview-build-message.sh | 23 ++++++ scripts/generate-preview-build-message.ts | 54 ------------- yarn.config.cjs | 14 ---- 65 files changed, 88 insertions(+), 196 deletions(-) create mode 100755 scripts/generate-preview-build-message.sh delete mode 100644 scripts/generate-preview-build-message.ts diff --git a/.github/workflows/publish-preview.yml b/.github/workflows/publish-preview.yml index 39e0ce3f7dd..666efb05d4e 100644 --- a/.github/workflows/publish-preview.yml +++ b/.github/workflows/publish-preview.yml @@ -9,6 +9,9 @@ jobs: name: Determine whether this issue comment was on a pull request from a fork if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '@metamaskbot publish-preview') }} runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: read outputs: IS_FORK: ${{ steps.is-fork.outputs.IS_FORK }} steps: @@ -17,23 +20,46 @@ jobs: id: is-fork run: echo "IS_FORK=$(gh pr view --json isCrossRepository --jq '.isCrossRepository' "${PR_NUMBER}" )" >> "$GITHUB_OUTPUT" env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - publish-preview: - name: Publish build preview + react-to-comment: + name: React to the comment needs: is-fork-pull-request - permissions: - pull-requests: write # This ensures we don't publish on forks. We can't trust forks with this token. if: ${{ needs.is-fork-pull-request.outputs.IS_FORK == 'false' }} runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + steps: + - uses: actions/checkout@v4 + - name: React to the comment + run: | + gh api \ + --method POST \ + -H "Accept: application/vnd.github+json" \ + -H "X-GitHub-Api-Version: 2022-11-28" \ + "/repos/${REPO}/issues/comments/${COMMENT_ID}/reactions" \ + -f content='+1' + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + COMMENT_ID: ${{ github.event.comment.id }} + REPO: ${{ github.repository }} + + publish-preview: + name: Publish build preview + needs: react-to-comment + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write steps: - uses: actions/checkout@v4 - name: Check out pull request run: gh pr checkout "${PR_NUMBER}" env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} - name: Checkout and setup environment uses: MetaMask/action-checkout-and-setup@v1 @@ -42,17 +68,15 @@ jobs: - name: Get commit SHA id: commit-sha run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT" - - run: yarn prepare-preview-builds @metamask-previews ${{ steps.commit-sha.outputs.COMMIT_SHA }} + - run: ./scripts/prepare-preview-builds.sh @metamask-previews ${{ steps.commit-sha.outputs.COMMIT_SHA }} - run: yarn build - - name: Publish preview build - run: yarn publish-previews + - name: Publish preview builds + run: yarn workspaces foreach --all --no-private --parallel --verbose run yarn npm publish --tag preview env: YARN_NPM_AUTH_TOKEN: ${{ secrets.PUBLISH_PREVIEW_NPM_TOKEN }} - - name: Generate preview build message - run: yarn tsx scripts/generate-preview-build-message.ts - - name: Post build preview in comment - run: gh pr comment "${PR_NUMBER}" --body-file preview-build-message.txt + - name: Post list of preview build identifiers + run: ./scripts/generate-preview-build-message.sh | gh pr comment "${PR_NUMBER}" --body-file - env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} COMMIT_SHA: ${{ steps.commit-sha.outputs.COMMIT_SHA }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.issue.number }} diff --git a/docs/contributing.md b/docs/contributing.md index d40b2b3d462..904d2164650 100644 --- a/docs/contributing.md +++ b/docs/contributing.md @@ -129,70 +129,44 @@ If you're developing your project locally and want to test changes to a package, 3. Due to the use of Yarn's `file:` protocol, if you update the package in the monorepo, then you'll need to run `yarn install` in the project again. -### Testing changes to packages with preview builds +## Testing changes against other projects using preview builds -If you want to test changes to a package where it would be unwieldy or impossible to use a local version, such as on CI, you can publish a preview build and configure your project to use it. +If you are working on a pull request and want to test changes to one or more packages in another project before you publish them, you can create _preview builds_ and then configure your project to use them. -#### Publishing preview builds as a MetaMask contributor - -If you're a member of the MetaMask organization, you can create preview builds based on a pull request by following these steps: - -1. Post a comment on the pull request with the text `@metamaskbot publish-preview`. This starts the `publish-preview` GitHub action, which will create preview builds for all packages in the monorepo. -2. After a few minutes, the action should complete and you will see a new comment that lists the newly published packages along with their versions. - - Note two things about each package: +### Creating preview builds +1. Within your pull request, post a comment with the text `@metamaskbot publish-preview`. This starts the `publish-preview` GitHub action, which will build all of the packages as they exist on the branch and publish them to NPM under a special namespace. +2. After a few minutes, the action should complete and you will see a new comment. Note two things: - The name is scoped to `@metamask-previews` instead of `@metamask`. - The ID of the last commit in the branch is appended to the version, e.g. `1.2.3-preview-e2df9b4` instead of `1.2.3`. -Now you can [use these preview builds in your project](#using-preview-builds). - -If you make more changes to a package, follow step 2 again, making sure to update the reference to the package in your project's `package.json` to use the newly published preview version. - -#### Publishing preview builds as an independent contributor - -If you've forked this repository, you can create preview builds based on a branch by following these steps: - -1. First, since an NPM scope is used to host preview build releases, you'll need access to one. If you do not, you can either [create a new organization](https://www.npmjs.com/org/create) or [convert your existing username into an organization](https://www.npmjs.com/org/upgrade). - -2. Once you've done this, open the `package.json` for each package that you want to publish and change the scope in the name from `@metamask` to `@`, replacing `NPM_ORG` with your NPM organization. - -3. Next, run the following command to create and publish the preview builds (again, replacing `NPM_ORG` as appropriate): - - ``` - yarn prepare-preview-builds "@" "$(git rev-parse --short HEAD)" && yarn build && yarn publish-previews - ``` - - You should be able to see the published version of each package in the output. Note two things: - - - The name is scoped to the NPM organization you entered instead of `@metamask`. - - The ID of the last commit in the branch is appended to the version, e.g. `1.2.3-preview-e2df9b4` instead of `1.2.3`. - -Now you can [use these preview builds in your project](#using-preview-builds). - -If you make more changes to a package, follow step 3 again, making sure to update the reference to the package in your project's `package.json` to use the newly published preview version. +### Using preview builds -#### Using preview builds +To use preview builds within a project, you need to override the resolution logic for your package manager so that the "production" version of that package is replaced with the preview version. Here's how you do that: -To use a preview build for a package within a project, you need to override the resolution logic for your package manager so that the "production" version of that package is replaced with the preview version. Here's how you do that: - -1. Open `package.json` in the project and locate the dependency entry for the core package for which you want to use a preview build. +1. Open `package.json` in the project and locate the entry for this package in `dependencies`. 2. Locate the section responsible for resolution overrides (or create it if it doesn't exist). If you're using Yarn, this is `resolutions`; if you're using NPM or any other package manager, this is `overrides`. -3. Add a line to this section that mirrors the dependency entry on the left-hand side and points to the preview version on the right-hand side: +3. Add a line to this section that mirrors the dependency entry on the left-hand side and points to the preview version on the right-hand side. Note the exact format of the left-hand side will differ based on which version of Yarn or NPM you are using. For example: + - For Yarn Modern, you will add something like this to `resolutions`: + ``` + "@metamask/foo-controller@^1.2.3": "npm:@metamask-previews/foo-controller@1.2.3-preview-abcdefg" + ``` + - For Yarn Classic, you will add something like this to `resolutions`: + ``` + "@metamask/foo-controller": "npm:@metamask-previews/foo-controller@1.2.3-preview-abcdefg" + ``` + - For NPM, you will add something like this to `overrides`: + ``` + "@metamask/foo-controller": "npm:@metamask-previews/foo-controller@1.2.3-preview-abcdefg" + ``` +4. Run `yarn install`. - ``` - "@metamask/@": "npm:@/@" - ``` +### Updating preview builds - > **Example:** - > - > - If your project uses Yarn, `@metamask/controller-utils` is listed in dependencies at `^1.1.4`, and you want to use the preview version `1.2.3-preview-e2df9b4`, add the following to `resolutions`: - > - > ``` - > "@metamask/controller-utils@^1.1.4": "npm:@metamask-previews/controller-utils@1.2.3-preview-e2df9b4" - > ``` +If you make more changes to your pull request and want to create a new set of preview builds: -4. Run `yarn install`. +1. Post another `@metamaskbot` comment on the pull request and wait for the response. +2. Update the version of the preview builds in your project's `package.json`. Make sure to re-run `yarn install`! ## Releasing changes diff --git a/package.json b/package.json index 878e1e27e20..a98ce017903 100644 --- a/package.json +++ b/package.json @@ -30,8 +30,6 @@ "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore", "lint:teams": "tsx scripts/lint-teams-json.ts", "prepack": "./scripts/prepack.sh", - "prepare-preview-builds": "./scripts/prepare-preview-builds.sh", - "publish-previews": "yarn workspaces foreach --all --no-private --parallel --verbose run publish:preview", "setup": "yarn install", "test": "yarn test:scripts --silent --collectCoverage=false --reporters=jest-silent-reporter && yarn test:packages", "test:clean": "yarn workspaces foreach --all --parallel --verbose run test:clean && yarn test", diff --git a/packages/account-tree-controller/package.json b/packages/account-tree-controller/package.json index 25042559b73..8953d4cf6f4 100644 --- a/packages/account-tree-controller/package.json +++ b/packages/account-tree-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/account-tree-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/account-tree-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/accounts-controller/package.json b/packages/accounts-controller/package.json index 1ee4d5c4c2f..641c3da2d45 100644 --- a/packages/accounts-controller/package.json +++ b/packages/accounts-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/accounts-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/accounts-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/address-book-controller/package.json b/packages/address-book-controller/package.json index 60805d92809..61c288d6ce7 100644 --- a/packages/address-book-controller/package.json +++ b/packages/address-book-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/address-book-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/address-book-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/announcement-controller/package.json b/packages/announcement-controller/package.json index 9b57eb85afe..6243b39d0c7 100644 --- a/packages/announcement-controller/package.json +++ b/packages/announcement-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/announcement-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/announcement-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/app-metadata-controller/package.json b/packages/app-metadata-controller/package.json index f38de98cd22..106656245f4 100644 --- a/packages/app-metadata-controller/package.json +++ b/packages/app-metadata-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/app-metadata-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/app-metadata-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/approval-controller/package.json b/packages/approval-controller/package.json index 3508796e19e..9ac682f410e 100644 --- a/packages/approval-controller/package.json +++ b/packages/approval-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/approval-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/approval-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/assets-controllers/package.json b/packages/assets-controllers/package.json index 06da1f641d7..bcb7afb8958 100644 --- a/packages/assets-controllers/package.json +++ b/packages/assets-controllers/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/assets-controllers", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/assets-controllers", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/base-controller/package.json b/packages/base-controller/package.json index 720031dc8e4..97a0caabe7d 100644 --- a/packages/base-controller/package.json +++ b/packages/base-controller/package.json @@ -50,7 +50,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/base-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/base-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/bridge-controller/package.json b/packages/bridge-controller/package.json index 6f9d23c4e8e..0de2a084efd 100644 --- a/packages/bridge-controller/package.json +++ b/packages/bridge-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/bridge-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/bridge-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/bridge-status-controller/package.json b/packages/bridge-status-controller/package.json index d3a3581d1a7..7572f46a5cc 100644 --- a/packages/bridge-status-controller/package.json +++ b/packages/bridge-status-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/bridge-status-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/bridge-status-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/build-utils/package.json b/packages/build-utils/package.json index a8186380843..483fa29171a 100644 --- a/packages/build-utils/package.json +++ b/packages/build-utils/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/build-utils", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/build-utils", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/chain-agnostic-permission/package.json b/packages/chain-agnostic-permission/package.json index 11316630a9d..84fd917059c 100644 --- a/packages/chain-agnostic-permission/package.json +++ b/packages/chain-agnostic-permission/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/chain-agnostic-permission", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/chain-agnostic-permission", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/composable-controller/package.json b/packages/composable-controller/package.json index f3f1d05095c..5db1d34610d 100644 --- a/packages/composable-controller/package.json +++ b/packages/composable-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/composable-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/composable-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/controller-utils/package.json b/packages/controller-utils/package.json index bce7f6a6ed2..d27acdb085b 100644 --- a/packages/controller-utils/package.json +++ b/packages/controller-utils/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/controller-utils", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/controller-utils", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/core-backend/package.json b/packages/core-backend/package.json index 6167c0885d5..f7817138aae 100644 --- a/packages/core-backend/package.json +++ b/packages/core-backend/package.json @@ -40,7 +40,6 @@ "changelog:update": "../../scripts/update-changelog.sh @metamask/core-backend", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/core-backend", "since-latest-release": "../../scripts/since-latest-release.sh", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/delegation-controller/package.json b/packages/delegation-controller/package.json index c6739c344cc..67615680175 100644 --- a/packages/delegation-controller/package.json +++ b/packages/delegation-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/delegation-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/delegation-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/earn-controller/package.json b/packages/earn-controller/package.json index a7b4b8cf8af..aa2b6a1d475 100644 --- a/packages/earn-controller/package.json +++ b/packages/earn-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/earn-controller", "changelog:update": "../../scripts/update-changelog.sh @metamask/earn-controller", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/eip-5792-middleware/package.json b/packages/eip-5792-middleware/package.json index b44fc9cae8e..6973203f830 100644 --- a/packages/eip-5792-middleware/package.json +++ b/packages/eip-5792-middleware/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/eip-5792-middleware", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/eip-5792-middleware", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/eip-7702-internal-rpc-middleware/package.json b/packages/eip-7702-internal-rpc-middleware/package.json index 558f310fc50..16e3cc7420c 100644 --- a/packages/eip-7702-internal-rpc-middleware/package.json +++ b/packages/eip-7702-internal-rpc-middleware/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/eip-7702-internal-rpc-middleware", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/eip-7702-internal-rpc-middleware", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/eip1193-permission-middleware/package.json b/packages/eip1193-permission-middleware/package.json index f6289dc132f..75a10435788 100644 --- a/packages/eip1193-permission-middleware/package.json +++ b/packages/eip1193-permission-middleware/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/eip1193-permission-middleware", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/eip1193-permission-middleware", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/ens-controller/package.json b/packages/ens-controller/package.json index b1ed3079146..d72a673a5dc 100644 --- a/packages/ens-controller/package.json +++ b/packages/ens-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/ens-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/ens-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/error-reporting-service/package.json b/packages/error-reporting-service/package.json index 735d5676174..644791243ba 100644 --- a/packages/error-reporting-service/package.json +++ b/packages/error-reporting-service/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/error-reporting-service", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/error-reporting-service", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/eth-block-tracker/package.json b/packages/eth-block-tracker/package.json index 3c3581d1321..51da14784c4 100644 --- a/packages/eth-block-tracker/package.json +++ b/packages/eth-block-tracker/package.json @@ -46,7 +46,6 @@ "lint:eslint": "eslint . --cache --ext js,ts", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies", "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/eth-json-rpc-middleware/package.json b/packages/eth-json-rpc-middleware/package.json index c91bb97f148..7a96146ba55 100644 --- a/packages/eth-json-rpc-middleware/package.json +++ b/packages/eth-json-rpc-middleware/package.json @@ -46,7 +46,6 @@ "lint:eslint": "eslint . --cache --ext js,ts", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies && yarn lint:changelog", "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/eth-json-rpc-provider/package.json b/packages/eth-json-rpc-provider/package.json index a4c941bebb8..c469ff46190 100644 --- a/packages/eth-json-rpc-provider/package.json +++ b/packages/eth-json-rpc-provider/package.json @@ -44,7 +44,6 @@ "lint:eslint": "eslint . --cache --ext js,ts", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies", "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/foundryup/package.json b/packages/foundryup/package.json index e27f0c17935..e3ae9d5524a 100644 --- a/packages/foundryup/package.json +++ b/packages/foundryup/package.json @@ -31,7 +31,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/foundryup", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/foundryup", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/gas-fee-controller/package.json b/packages/gas-fee-controller/package.json index ecd36f458e3..b794cbe4827 100644 --- a/packages/gas-fee-controller/package.json +++ b/packages/gas-fee-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/gas-fee-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/gas-fee-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/gator-permissions-controller/package.json b/packages/gator-permissions-controller/package.json index 6ac5b507e3f..73a695f01b7 100644 --- a/packages/gator-permissions-controller/package.json +++ b/packages/gator-permissions-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/gator-permissions-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/gator-permissions-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/json-rpc-engine/package.json b/packages/json-rpc-engine/package.json index 088e5396a5f..4fb73c9c9d2 100644 --- a/packages/json-rpc-engine/package.json +++ b/packages/json-rpc-engine/package.json @@ -48,7 +48,6 @@ "lint:eslint": "eslint . --cache --ext js,ts", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies && yarn lint:changelog", "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/json-rpc-middleware-stream/package.json b/packages/json-rpc-middleware-stream/package.json index 8913428aa52..ebe09b91c2b 100644 --- a/packages/json-rpc-middleware-stream/package.json +++ b/packages/json-rpc-middleware-stream/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/json-rpc-middleware-stream --tag-prefix-before-package-rename json-rpc-middleware-stream@ --version-before-package-rename 5.0.1", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/json-rpc-middleware-stream --tag-prefix-before-package-rename json-rpc-middleware-stream@ --version-before-package-rename 5.0.1", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/keyring-controller/package.json b/packages/keyring-controller/package.json index 44905590306..31b55c80ebf 100644 --- a/packages/keyring-controller/package.json +++ b/packages/keyring-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/keyring-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/keyring-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/logging-controller/package.json b/packages/logging-controller/package.json index 6e0817e55e5..f3c1e3c3b84 100644 --- a/packages/logging-controller/package.json +++ b/packages/logging-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/logging-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/logging-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/message-manager/package.json b/packages/message-manager/package.json index 34c1bd9f759..7c349656076 100644 --- a/packages/message-manager/package.json +++ b/packages/message-manager/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/message-manager", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/message-manager", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/messenger/package.json b/packages/messenger/package.json index d473644095e..10969104307 100644 --- a/packages/messenger/package.json +++ b/packages/messenger/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/messenger", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/messenger", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/multichain-account-service/package.json b/packages/multichain-account-service/package.json index 51c53b18ae3..9a3360b3f64 100644 --- a/packages/multichain-account-service/package.json +++ b/packages/multichain-account-service/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/multichain-account-service", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/multichain-account-service", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/multichain-api-middleware/package.json b/packages/multichain-api-middleware/package.json index 3794ca69f40..c98310ba58c 100644 --- a/packages/multichain-api-middleware/package.json +++ b/packages/multichain-api-middleware/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/multichain-api-middleware", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/multichain-api-middleware", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/multichain-network-controller/package.json b/packages/multichain-network-controller/package.json index 0dcdf0e8bca..56cb06995cf 100644 --- a/packages/multichain-network-controller/package.json +++ b/packages/multichain-network-controller/package.json @@ -43,8 +43,7 @@ "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", - "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch", - "publish:preview": "yarn npm publish --tag preview" + "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch" }, "dependencies": { "@metamask/base-controller": "^8.4.2", diff --git a/packages/multichain-transactions-controller/package.json b/packages/multichain-transactions-controller/package.json index 0b8433f6d87..e8ba95236bc 100644 --- a/packages/multichain-transactions-controller/package.json +++ b/packages/multichain-transactions-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/multichain-transactions-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/multichain-transactions-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/name-controller/package.json b/packages/name-controller/package.json index b69d9576649..1f66274ed76 100644 --- a/packages/name-controller/package.json +++ b/packages/name-controller/package.json @@ -40,7 +40,6 @@ "changelog:update": "../../scripts/update-changelog.sh @metamask/name-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/name-controller", "prepare-manifest:preview": "../../scripts/prepare-preview-manifest.sh", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/network-controller/package.json b/packages/network-controller/package.json index 466aa862c68..3e3bef250b2 100644 --- a/packages/network-controller/package.json +++ b/packages/network-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/network-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/network-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/network-enablement-controller/package.json b/packages/network-enablement-controller/package.json index 8f0802e5f0a..ac3c283e51e 100644 --- a/packages/network-enablement-controller/package.json +++ b/packages/network-enablement-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/network-enablement-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/network-enablement-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/notification-services-controller/package.json b/packages/notification-services-controller/package.json index 276cc11b400..44f3d0c9c67 100644 --- a/packages/notification-services-controller/package.json +++ b/packages/notification-services-controller/package.json @@ -101,7 +101,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/notification-services-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/notification-services-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/permission-controller/package.json b/packages/permission-controller/package.json index 8fb6be422ec..60b4393271b 100644 --- a/packages/permission-controller/package.json +++ b/packages/permission-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/permission-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/permission-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/permission-log-controller/package.json b/packages/permission-log-controller/package.json index ac112e105ab..0f1e59f5775 100644 --- a/packages/permission-log-controller/package.json +++ b/packages/permission-log-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/permission-log-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/permission-log-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/phishing-controller/package.json b/packages/phishing-controller/package.json index a8cb12be4d4..f5ed341fb9b 100644 --- a/packages/phishing-controller/package.json +++ b/packages/phishing-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/phishing-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/phishing-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/polling-controller/package.json b/packages/polling-controller/package.json index 766e3a27393..4f54805ecf4 100644 --- a/packages/polling-controller/package.json +++ b/packages/polling-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/polling-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/polling-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/preferences-controller/package.json b/packages/preferences-controller/package.json index 07ed6ad584f..4f87fb15486 100644 --- a/packages/preferences-controller/package.json +++ b/packages/preferences-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/preferences-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/preferences-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/profile-sync-controller/package.json b/packages/profile-sync-controller/package.json index 0aa64138331..cbef9eb0d25 100644 --- a/packages/profile-sync-controller/package.json +++ b/packages/profile-sync-controller/package.json @@ -92,7 +92,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/profile-sync-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/profile-sync-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/rate-limit-controller/package.json b/packages/rate-limit-controller/package.json index 5814ac6527a..a8005b0147b 100644 --- a/packages/rate-limit-controller/package.json +++ b/packages/rate-limit-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/rate-limit-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/rate-limit-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/remote-feature-flag-controller/package.json b/packages/remote-feature-flag-controller/package.json index 6710bc1f85e..f3a2dee10a9 100644 --- a/packages/remote-feature-flag-controller/package.json +++ b/packages/remote-feature-flag-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/remote-feature-flag-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/remote-feature-flag-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/sample-controllers/package.json b/packages/sample-controllers/package.json index af27d67700b..40983305a22 100644 --- a/packages/sample-controllers/package.json +++ b/packages/sample-controllers/package.json @@ -40,7 +40,6 @@ "changelog:update": "../../scripts/update-changelog.sh @metamask/sample-controllers", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/sample-controllers", "since-latest-release": "../../scripts/since-latest-release.sh", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/seedless-onboarding-controller/package.json b/packages/seedless-onboarding-controller/package.json index 530b23a2890..b56131aee84 100644 --- a/packages/seedless-onboarding-controller/package.json +++ b/packages/seedless-onboarding-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/seedless-onboarding-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/seedless-onboarding-controller", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/selected-network-controller/package.json b/packages/selected-network-controller/package.json index 14f4dc8ca52..61edaba79bf 100644 --- a/packages/selected-network-controller/package.json +++ b/packages/selected-network-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/selected-network-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/selected-network-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/shield-controller/package.json b/packages/shield-controller/package.json index 5b26ce1442e..dc25dd94374 100644 --- a/packages/shield-controller/package.json +++ b/packages/shield-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/shield-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/shield-controller", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/signature-controller/package.json b/packages/signature-controller/package.json index 5280836ff41..186d9916872 100644 --- a/packages/signature-controller/package.json +++ b/packages/signature-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/signature-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/signature-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/subscription-controller/package.json b/packages/subscription-controller/package.json index e2e13bb5bca..bc4624f6c0e 100644 --- a/packages/subscription-controller/package.json +++ b/packages/subscription-controller/package.json @@ -40,7 +40,6 @@ "changelog:update": "../../scripts/update-changelog.sh @metamask/subscription-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/subscription-controller", "since-latest-release": "../../scripts/since-latest-release.sh", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/token-search-discovery-controller/package.json b/packages/token-search-discovery-controller/package.json index 2d22854289e..ef0ed69ad0b 100644 --- a/packages/token-search-discovery-controller/package.json +++ b/packages/token-search-discovery-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/token-search-discovery-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/token-search-discovery-controller", - "publish:preview": "yarn npm publish --tag preview", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", "test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose", diff --git a/packages/transaction-controller/package.json b/packages/transaction-controller/package.json index bfcc026a19a..800b09114f3 100644 --- a/packages/transaction-controller/package.json +++ b/packages/transaction-controller/package.json @@ -39,7 +39,6 @@ "build:docs": "typedoc", "changelog:update": "../../scripts/update-changelog.sh @metamask/transaction-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/transaction-controller", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/packages/user-operation-controller/package.json b/packages/user-operation-controller/package.json index baf88dcaaeb..9752f4d5adc 100644 --- a/packages/user-operation-controller/package.json +++ b/packages/user-operation-controller/package.json @@ -40,7 +40,6 @@ "changelog:update": "../../scripts/update-changelog.sh @metamask/user-operation-controller", "changelog:validate": "../../scripts/validate-changelog.sh @metamask/user-operation-controller", "prepare-manifest:preview": "../../scripts/prepare-preview-manifest.sh", - "publish:preview": "yarn npm publish --tag preview", "since-latest-release": "../../scripts/since-latest-release.sh", "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter", "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache", diff --git a/scripts/generate-preview-build-message.sh b/scripts/generate-preview-build-message.sh new file mode 100755 index 00000000000..b5927c77eef --- /dev/null +++ b/scripts/generate-preview-build-message.sh @@ -0,0 +1,23 @@ +#!/usr/bin/env bash + +main() { + local identifiers="$(./scripts/list-workspace-versions.sh --json | jq --raw-output 'map("npm:" + .name + "@" + .version) | .[]')" + + cat < + +Expand for the full list. + +``` +${identifiers} +``` + + + +[Learn more about preview builds.](https://github.com/MetaMask/core/blob/main/docs/contributing.md#testing-changes-against-other-projects-using-preview-builds) +EOT +} + +main "$@" diff --git a/scripts/generate-preview-build-message.ts b/scripts/generate-preview-build-message.ts deleted file mode 100644 index 7981f3136b9..00000000000 --- a/scripts/generate-preview-build-message.ts +++ /dev/null @@ -1,54 +0,0 @@ -#!yarn tsx - -import execa from 'execa'; -import fs from 'fs'; -import path from 'path'; - -/** - * Write a preview build message to the path "preview-build-message.txt". - */ -async function main() { - const packageMap: Record = {}; - - const { stdout } = await execa('yarn', [ - 'workspaces', - 'list', - '--no-private', - '--json', - ]); - const packages = stdout.split('\n').map((line) => JSON.parse(line)); - const packageManifestPaths = packages.map(({ location }) => - path.join(location, 'package.json'), - ); - for (const manifestPath of packageManifestPaths) { - const rawManifest = await fs.promises.readFile(manifestPath, { - encoding: 'utf8', - }); - const { name, version } = JSON.parse(rawManifest); - - packageMap[name] = version; - } - - const previewBuildMessage = ` -Preview builds have been published. [See these instructions](https://github.com/MetaMask/core/blob/main/docs/contributing.md#using-packages-in-other-projects-during-developmenttesting) for more information about preview builds. - -
- -Expand for full list of packages and versions. - - -\`\`\` -${JSON.stringify(packageMap, null, 2)} -\`\`\` - -
-`; - - const messagePath = path.resolve(__dirname, '../preview-build-message.txt'); - await fs.promises.writeFile(messagePath, previewBuildMessage); -} - -main().catch((error) => { - console.error(error); - process.exitCode = 1; -}); diff --git a/yarn.config.cjs b/yarn.config.cjs index 8a5002908cd..8c02dab0a6d 100644 --- a/yarn.config.cjs +++ b/yarn.config.cjs @@ -123,20 +123,6 @@ module.exports = defineConfig({ // All non-root packages must have the same "build:docs" script. expectWorkspaceField(workspace, 'scripts.build:docs', 'typedoc'); - if (isPrivate) { - // All private, non-root packages must not have a "publish:preview" - // script. - workspace.unset('scripts.publish:preview'); - } else { - // All non-private, non-root packages must have the same - // "publish:preview" script. - expectWorkspaceField( - workspace, - 'scripts.publish:preview', - 'yarn npm publish --tag preview', - ); - } - // No non-root packages may have a "prepack" script. workspace.unset('scripts.prepack'); From b5dc52a49afbf2f8e5d893d9961f1795ad538d0c Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Fri, 24 Oct 2025 09:21:46 -0600 Subject: [PATCH 2/2] Fix workflow --- .github/workflows/publish-preview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-preview.yml b/.github/workflows/publish-preview.yml index 666efb05d4e..4fe5dc9182e 100644 --- a/.github/workflows/publish-preview.yml +++ b/.github/workflows/publish-preview.yml @@ -71,7 +71,7 @@ jobs: - run: ./scripts/prepare-preview-builds.sh @metamask-previews ${{ steps.commit-sha.outputs.COMMIT_SHA }} - run: yarn build - name: Publish preview builds - run: yarn workspaces foreach --all --no-private --parallel --verbose run yarn npm publish --tag preview + run: yarn workspaces foreach --all --no-private --parallel --verbose run npm publish --tag preview env: YARN_NPM_AUTH_TOKEN: ${{ secrets.PUBLISH_PREVIEW_NPM_TOKEN }} - name: Post list of preview build identifiers