Refs: #61 Oracle CommitStampStart recursion fix and add related tests

Author: AGiorgetti

Changelog.md

@@ -14,6 +14,7 @@
 
 - Fix cross-bucket contamination in snapshot candidate query [#59](https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/59)
 - Fix async paged-query infinite loop when PageSize is zero [#60](https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/60)
+- Fix Oracle CommitStampStart recursion [#61](https://github.com/NEventStore/NEventStore.Persistence.SQL/issues/61)
 
 ### Breaking Changes
 

docs/Project-Analysis-Issue-Drafts.md

@@ -282,7 +282,7 @@ Validation:
 
 ### Issue #60: Async Infinite Page Size Empty Reads
 
-Status: completed locally on 2026-06-11. GitHub issue update is pending review.
+Status: completed on 2026-06-11.
 
 Async paged reads now complete when the configured page size is `0`. For pageable dialects, `ExecutePagedQueryAsync` still binds the SQL limit parameter with an effectively unbounded value, but keeps the local paging size at `0` so continuation does not request another page.
 
@@ -303,3 +303,29 @@ Validation:
 - Result: 2 passed, 0 failed, 0 skipped.
 - `dotnet build .\src\NEventStore.Persistence.Sql.Core.sln -c Release --no-restore /p:ContinuousIntegrationBuild=true -m:1 -nr:false`
 - Result: passed.
+
+### Issue #61: Oracle CommitStampStart Recursion
+
+Status: completed on 2026-06-11. GitHub issue updated in comment `4681420070`.
+
+Oracle date-range reads no longer recurse while binding `CommitStampStart`. `OracleNativeDialect.CommitStampStart` now wraps `base.CommitStampStart`, matching the other Oracle parameter overrides. The Oracle dialect also now provides an Oracle-native `GetCommitsFromToInstant` statement, because the new integration coverage showed that after the recursion was fixed, Oracle was still falling back to the common `LIMIT/OFFSET` date-range SQL.
+
+Implementation notes:
+
+- Added Oracle regression coverage under `src/NEventStore.Persistence.Oracle.Tests/OracleCommitStampStartTests.cs`.
+- The direct dialect test verifies `new OracleNativeDialect().CommitStampStart` returns `:CommitStampStart`.
+- The Oracle integration test commits two events in one bucket and verifies `GetFromTo(bucketId, startDate, endDate)` returns only the commit inside the requested timestamp range.
+- The production fix is scoped to Oracle dialect parameter and date-range SQL behavior.
+
+Validation:
+
+- Test-first check: the new Oracle date-range regression crashed the test host before the fix with a stack overflow in `OracleNativeDialect.get_CommitStampStart`.
+- After the getter fix, the same regression exposed Oracle fallback to common `LIMIT/OFFSET` date-range SQL; adding the Oracle-native date-range statement fixed that provider issue.
+- `dotnet test .\src\NEventStore.Persistence.Oracle.Tests\NEventStore.Persistence.Oracle.Core.Tests.csproj -c Release -f net8.0 --no-build --filter "FullyQualifiedName~when_getting_the_oracle_commit_stamp_start_parameter"`
+- Result: 1 passed, 0 failed, 0 skipped.
+- `dotnet test .\src\NEventStore.Persistence.Oracle.Tests\NEventStore.Persistence.Oracle.Core.Tests.csproj -c Release -f net8.0 --no-restore --filter "FullyQualifiedName~CommitStampStart|FullyQualifiedName~when_reading_oracle_commits_between_commit_stamps"`
+- Result: 2 passed, 0 failed, 0 skipped.
+- `dotnet test .\src\NEventStore.Persistence.Oracle.Tests\NEventStore.Persistence.Oracle.Core.Tests.csproj -c Release -f net8.0 --no-build`
+- Result: 146 passed, 0 failed, 0 skipped.
+- `dotnet build .\src\NEventStore.Persistence.Sql.Core.sln -c Release --no-restore /p:ContinuousIntegrationBuild=true -m:1 -nr:false`
+- Result: passed.

src/NEventStore.Persistence.Oracle.Tests/OracleCommitStampStartTests.cs

@@ -0,0 +1,75 @@
+#pragma warning disable IDE1006 // Naming Styles
+
+using FluentAssertions;
+using NEventStore.Persistence.AcceptanceTests;
+using NEventStore.Persistence.AcceptanceTests.BDD;
+using NEventStore.Persistence.Sql.SqlDialects;
+using NUnit.Framework;
+
+namespace NEventStore.Persistence.Oracle.Tests
+{
+	public class when_getting_the_oracle_commit_stamp_start_parameter
+	{
+		private Exception? _thrown;
+		private string? _parameterName;
+
+		[SetUp]
+		public void SetUp()
+		{
+			_thrown = Catch.Exception(() => _parameterName = new OracleNativeDialect().CommitStampStart);
+		}
+
+		[Test]
+		public void should_return_the_oracle_parameter_name_without_recursing()
+		{
+			_thrown.Should().BeNull();
+			_parameterName.Should().Be(":CommitStampStart");
+		}
+	}
+}
+
+namespace NEventStore.Persistence.AcceptanceTests
+{
+	public class when_reading_oracle_commits_between_commit_stamps : PersistenceEngineConcern
+	{
+		private const string BucketId = "oracle-date-range";
+		private CommitAttempt? _insideRange;
+		private CommitAttempt? _outsideRange;
+		private ICommit[]? _commits;
+		private Exception? _thrown;
+
+		protected override void Context()
+		{
+			DateTime start = SystemTime.UtcNow.AddYears(1);
+			_insideRange = Guid.NewGuid().ToString().BuildAttempt(start.AddSeconds(1), BucketId);
+			_outsideRange = Guid.NewGuid().ToString().BuildAttempt(start.AddMinutes(5), BucketId);
+
+			Persistence.Commit(_insideRange);
+			Persistence.Commit(_outsideRange);
+		}
+
+		protected override void Because()
+		{
+			DateTime startDate = _insideRange!.CommitStamp.AddSeconds(-1);
+			DateTime endDate = _insideRange.CommitStamp.AddSeconds(1);
+
+			_thrown = Catch.Exception(() =>
+				_commits = Persistence.GetFromTo(BucketId, startDate, endDate).ToArray());
+		}
+
+		[Test]
+		public void should_query_the_date_range_without_recursing()
+		{
+			_thrown.Should().BeNull();
+		}
+
+		[Test]
+		public void should_return_only_commits_inside_the_requested_range()
+		{
+			_commits.Should().ContainSingle(x => x.CommitId == _insideRange!.CommitId);
+			_commits.Should().NotContain(x => x.CommitId == _outsideRange!.CommitId);
+		}
+	}
+}
+
+#pragma warning restore IDE1006 // Naming Styles

src/NEventStore.Persistence.Sql/SqlDialects/OracleNativeDialect.cs

@@ -54,7 +54,7 @@ public override string CommitStampEnd
 		/// <inheritdoc/>
 		public override string CommitStampStart
 		{
-			get { return MakeOracleParameter(CommitStampStart); }
+			get { return MakeOracleParameter(base.CommitStampStart); }
 		}
 		/// <inheritdoc/>
 		public override string DuplicateCommit
@@ -77,6 +77,11 @@ public override string GetCommitsFromInstant
 			get { return OraclePaging(OracleNativeStatements.GetCommitsFromInstant); }
 		}
 		/// <inheritdoc/>
+		public override string GetCommitsFromToInstant
+		{
+			get { return OraclePaging(OracleNativeStatements.GetCommitsFromToInstant); }
+		}
+		/// <inheritdoc/>
 		public override string GetCommitsFromCheckpoint
 		{
 			get { return OraclePaging(OracleNativeStatements.GetCommitsSinceCheckpoint); }

src/NEventStore.Persistence.Sql/SqlDialects/OracleNativeStatements.Designer.cs

@@ -165,6 +165,15 @@ WHERE	(
 SELECT BucketId, StreamId, StreamIdOriginal, StreamRevision, CommitId, CommitSequence, CommitStamp, CheckpointNumber, Headers, Payload
 FROM Commits
 WHERE BucketId = :BucketId AND CommitStamp >= :CommitStamp
+ORDER BY CheckpointNumber</value>
+  </data>
+  <data name="GetCommitsFromToInstant" xml:space="preserve">
+    <value>/*GetCommitsFromToInstant*/
+SELECT BucketId, StreamId, StreamIdOriginal, StreamRevision, CommitId, CommitSequence, CommitStamp, CheckpointNumber, Headers, Payload
+FROM Commits
+WHERE BucketId = :BucketId
+   AND CommitStamp &gt;= :CommitStampStart
+   AND CommitStamp &lt; :CommitStampEnd
 ORDER BY CheckpointNumber</value>
   </data>
   <data name="GetCommitsFromStartingRevision" xml:space="preserve">