From 54d499227c9e3ecfefcc98fc0dc6863c39f35962 Mon Sep 17 00:00:00 2001 From: Eric Niebler Date: Wed, 29 Apr 2026 13:58:08 -0700 Subject: [PATCH 1/2] fix feature test for constexpr virtual functions --- include/stdexec/__detail/__diagnostics.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/stdexec/__detail/__diagnostics.hpp b/include/stdexec/__detail/__diagnostics.hpp index 31f05b662..671bad8aa 100644 --- a/include/stdexec/__detail/__diagnostics.hpp +++ b/include/stdexec/__detail/__diagnostics.hpp @@ -149,7 +149,7 @@ namespace STDEXEC // constexpr stdlib exception types, https://wg21.link/p3378 using __exception = ::std::exception; -#elif __cpp_constexpr >= 202411L // constexpr virtual functions +#elif __cpp_constexpr >= 201907L // constexpr virtual functions // constexpr virtual functions struct __exception From 128216cf8c58e6d63ea3572db7c5402981aff737 Mon Sep 17 00:00:00 2001 From: Eric Niebler Date: Wed, 29 Apr 2026 17:51:46 -0700 Subject: [PATCH 2/2] give up on msvc and nvc++ --- include/stdexec/__detail/__diagnostics.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/stdexec/__detail/__diagnostics.hpp b/include/stdexec/__detail/__diagnostics.hpp index 671bad8aa..62af3a31c 100644 --- a/include/stdexec/__detail/__diagnostics.hpp +++ b/include/stdexec/__detail/__diagnostics.hpp @@ -144,12 +144,12 @@ namespace STDEXEC _WITH_PRETTY_SENDER_<_Sender>, _WITH_ENVIRONMENT_(_Env)...>; -#if __cpp_lib_constexpr_exceptions >= 202502L // constexpr exception types, https://wg21.link/p3378 +#if __cpp_lib_constexpr_exceptions >= 202502L // constexpr stdlib exception types, https://wg21.link/p3378 using __exception = ::std::exception; -#elif __cpp_constexpr >= 201907L // constexpr virtual functions +#elif __cpp_constexpr >= 201907L && !STDEXEC_MSVC() && !STDEXEC_NVHPC() // constexpr virtual functions struct __exception